Merge pull request #24 from mattieserver/19052020_dev_1

19052020 dev 1

README.md

@@ -1,7 +1,8 @@
 # Netbox Topology Views Plugin
 
 Create topology views/maps from your devices in netbox.
-Support to filter on name, site and device role.
+The connections are based on the cables you created in netbox.
+Support to filter on name, site, tag and device role.
 
 ## Preview
 
@@ -62,4 +63,4 @@ Run `pip install netbox-topology-views --upgrade` in your venv.
 
 Run `python3 manage.py collectstatic --no-input`
 
-Clear you browser cache.
+Clear your browser cache.

netbox_topology_views/__init__.py

@@ -4,7 +4,7 @@ class TopologyViewsConfig(PluginConfig):
     name = 'netbox_topology_views'
     verbose_name = 'Topology views'
     description = 'An plugin to render toplogoy maps'
-    version = '0.4.7'
+    version = '0.4.8'
     author = 'Mattijs Vanhaverbeke'
     author_email = 'author@example.com'
     base_url = 'topology-views'

netbox_topology_views/api/views.py

@@ -175,34 +175,40 @@ class SearchViewSet(GenericViewSet):
                                 title += "Circuit provider: "  + cable.termination_a.circuit.provider.name + "<br>"
                                 title += "Termination between <br>"
                                 title += cable_b_dev_name + " [" + cable_b_name +  "]<br>"
+                                # To Many if's
                                 if cable.termination_a.circuit.termination_a is not None:
                                     if cable.termination_a.circuit.termination_a.cable is not None:
                                         if cable.termination_a.circuit.termination_a.cable.id != cable.id:
-                                            edge["from"] = cable.termination_a.circuit.termination_a.cable.termination_b.device.id
+                                            if cable.termination_a.circuit.termination_a.cable.termination_b is not None:
+                                                if cable.termination_a.circuit.termination_a.cable.termination_b.device is not None:
+                                                    edge["from"] = cable.termination_a.circuit.termination_a.cable.termination_b.device.id
 
-                                            cable_a_dev_name = cable.termination_a.circuit.termination_a.cable.termination_b.device.name
-                                            if cable_a_dev_name is None:
-                                                cable_a_dev_name = "device B name unknown"
-                                            cable_b_name = cable.termination_a.circuit.termination_a.cable.termination_b.name
-                                            if cable_a_name is None:
-                                                cable_a_name = "cable B name unknown"
-                                            title += cable_a_dev_name + " [" + cable_a_name +  "]<br>"
+                                                    cable_a_dev_name = cable.termination_a.circuit.termination_a.cable.termination_b.device.name
+                                                    if cable_a_dev_name is None:
+                                                        cable_a_dev_name = "device B name unknown"
+                                                    cable_b_name = cable.termination_a.circuit.termination_a.cable.termination_b.name
+                                                    if cable_a_name is None:
+                                                        cable_a_name = "cable B name unknown"
+                                                    title += cable_a_dev_name + " [" + cable_a_name +  "]<br>"
+                                                    edge["title"] = title
+                                                    edges.append(edge)
+                                # To Many if's
                                 if cable.termination_a.circuit.termination_z is not None:
                                     if cable.termination_a.circuit.termination_z.cable is not None:
                                         if cable.termination_a.circuit.termination_z.cable.id != cable.id:
-                                            edge["from"] = cable.termination_a.circuit.termination_z.cable.termination_b.device.id
+                                            if cable.termination_a.circuit.termination_z.cable.termination_b is not None:
+                                                if cable.termination_a.circuit.termination_z.cable.termination_b.device is not None:
+                                                    edge["from"] = cable.termination_a.circuit.termination_z.cable.termination_b.device.id
 
-                                            cable_a_dev_name = cable.termination_a.circuit.termination_z.cable.termination_b.device.name
-                                            if cable_a_dev_name is None:
-                                                cable_a_dev_name = "device B name unknown"
-                                            cable_a_name = cable.termination_a.circuit.termination_z.cable.termination_b.name
-                                            if cable_a_name is None:
-                                                cable_a_name = "cable B name unknown"
-                                            title += cable_a_dev_name + " [" + cable_a_name +  "]<br>"
-
-                                edge["title"] = title
-                                edges.append(edge)
-                
+                                                    cable_a_dev_name = cable.termination_a.circuit.termination_z.cable.termination_b.device.name
+                                                    if cable_a_dev_name is None:
+                                                        cable_a_dev_name = "device B name unknown"
+                                                    cable_a_name = cable.termination_a.circuit.termination_z.cable.termination_b.name
+                                                    if cable_a_name is None:
+                                                        cable_a_name = "cable B name unknown"
+                                                    title += cable_a_dev_name + " [" + cable_a_name +  "]<br>"
+                                                    edge["title"] = title
+                                                    edges.append(edge)
             dev_name = device.name
             if dev_name is None:
                 dev_name = "device name unknown"

package.json

@@ -1,7 +1,7 @@
 {
   "private": true,
   "name": "netbox_topology_views",
-  "version": "0.4.7",
+  "version": "0.4.8",
   "scripts": {
     "resources": "gulp build",
     "resources_dev": "gulp build_dev"

setup.py

@@ -3,7 +3,7 @@ from setuptools import setup, find_packages
 
 setup(
     name='netbox-topology-views',
-    version='0.4.7',
+    version='0.4.8',
     description='An NetBox plugin to create Topology maps',
     url='https://github.com/mattieserver/netbox-topology-views',
     author='Mattijs Vanhaverbeke',