MrBlake/NetBox-SLM
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: handle NetBox form clean return value

Browse Source 
Read installation destinations from self.cleaned_data because NetBox 4.6.5 form mixins return None while cleaning newly created objects.
This commit is contained in:
MrBlake
2026-07-27 12:31:26 +02:00
parent 71a5db0ece
commit 9f3bddfbb1
4 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CHANGELOG.md
+1
View File
@@ -5,6 +5,7 @@
### Fixed ### Fixed
* Make the required single platform destination explicit when creating an installation * Make the required single platform destination explicit when creating an installation
* Fix installation form submission on NetBox v4.6.5 when form mixins return no cleaned-data value
### Added ### Added
README.md
+1 -1
View File
@@ -63,7 +63,7 @@ Die installierte Version kann anschließend geprüft werden:
/opt/netbox/venv/bin/pip show netbox-slm /opt/netbox/venv/bin/pip show netbox-slm
``` ```
Für diese Variante muss dort mindestens Version `1.11.1` stehen. Für diese Variante muss dort mindestens Version `1.11.2` stehen.
### 3. Plugin in NetBox aktivieren ### 3. Plugin in NetBox aktivieren
netbox_slm/__init__.py
+1 -1
View File
@@ -17,7 +17,7 @@ limitations under the License.
from netbox.plugins import PluginConfig from netbox.plugins import PluginConfig
from django.utils.translation import gettext_lazy as _ from django.utils.translation import gettext_lazy as _
__version__ = "1.11.1" __version__ = "1.11.2"
class SLMConfig(PluginConfig): class SLMConfig(PluginConfig):
netbox_slm/forms/software_product_installation.py
+5 -5
View File
@@ -75,15 +75,15 @@ class SoftwareProductInstallationForm(NetBoxModelForm):
return version return version
def clean(self): def clean(self):
cleaned_data = super().clean() super().clean()
destinations = [ destinations = [
cleaned_data.get("device"), self.cleaned_data.get("device"),
cleaned_data.get("virtualmachine"), self.cleaned_data.get("virtualmachine"),
cleaned_data.get("cluster"), self.cleaned_data.get("cluster"),
] ]
if sum(destination is not None for destination in destinations) != 1: if sum(destination is not None for destination in destinations) != 1:
raise ValidationError(_("Select exactly one platform destination: device, virtual machine, or cluster.")) raise ValidationError(_("Select exactly one platform destination: device, virtual machine, or cluster."))
return cleaned_data return self.cleaned_data
class SoftwareProductInstallationFilterForm(NetBoxModelFilterSetForm): class SoftwareProductInstallationFilterForm(NetBoxModelFilterSetForm):