fix: honor tenant validation during plugin imports

This commit is contained in:
2026-08-05 13:28:01 +02:00
parent f558832cd2
commit 7a018807d8
11 changed files with 139 additions and 8 deletions
+1 -1
View File
@@ -7,7 +7,7 @@ class NetBoxExportConfig(PluginConfig):
name = "netbox_export"
verbose_name = "NetBox-Export"
description = "Portable ZIP export and import for tenants and locations"
version = "0.3.2"
version = "0.3.3"
author = "NetBox Export contributors"
base_url = "netbox-export"
min_version = "4.6.0"
+1 -1
View File
@@ -39,7 +39,7 @@ def export_scope(
"created_at": datetime.now(UTC).isoformat(),
"source_instance": str(InstanceIdentity.local_id()),
"source_netbox_version": getattr(getattr(settings, "RELEASE", None), "version", "4.6"),
"plugin_version": "0.3.2",
"plugin_version": "0.3.3",
"scope": {
"type": scope_type,
"source_pk": str(scope_id),
+1
View File
@@ -40,6 +40,7 @@ def is_exportable_model(model) -> bool:
and not opts.abstract
and not opts.proxy
and not opts.auto_created
and not getattr(model, "_netbox_private", False)
and opts.app_label not in EXCLUDED_APP_LABELS
and opts.label_lower not in EXCLUDED_MODELS
)
+12 -4
View File
@@ -16,6 +16,10 @@ from netbox_export.models import ImportedObjectMapping
from .archive import ParsedArchive
from .codec import SKIP_FIELD_NAMES, decode_scalar, generic_foreign_keys
from .exceptions import ArchiveValidationError, ExportImportError, ImportConflictError
from .plugin_compat import (
netbox_utilities_tenant_required,
relation_required_before_save,
)
from .references import MISSING_REFERENCE, ReferenceResolver
EXPLICIT_IDENTITIES = {
@@ -210,7 +214,7 @@ def _write_mapping(source_instance, record, obj):
)
def _field_kwargs(model, record, resolver):
def _field_kwargs(model, record, resolver, *, tenant_required: bool):
valid_fields = {field.name: field for field in model._meta.concrete_fields}
kwargs = {}
unresolved = []
@@ -240,14 +244,17 @@ def _field_kwargs(model, record, resolver):
field = valid_fields.get(name)
if not isinstance(field, (models.ForeignKey, models.OneToOneField)):
continue
required_before_save = relation_required_before_save(field, tenant_required=tenant_required)
value, available = resolver.resolve(spec)
if available:
if value is MISSING_REFERENCE:
if not field.null and not field.has_default():
if required_before_save or (not field.null and not field.has_default()):
missing_required.append(name)
elif value is None and required_before_save:
missing_required.append(name)
else:
kwargs[name] = value
elif field.null:
elif field.null and not required_before_save:
unresolved.append((name, spec))
else:
return None, [], [], []
@@ -345,6 +352,7 @@ def import_archive(parsed: ParsedArchive, *, conflict_strategy: str, dry_run: bo
report = ImportReport(dry_run=dry_run, warnings=list(parsed.warnings))
resolved = {}
resolver = ReferenceResolver(resolved, report.warnings, _model_for)
tenant_required = netbox_utilities_tenant_required()
deferred_relations = []
deferred_generic = []
deferred_values = []
@@ -359,7 +367,7 @@ def import_archive(parsed: ParsedArchive, *, conflict_strategy: str, dry_run: bo
for record_id, record in list(pending.items()):
model = _model_for(record["model"])
kwargs, unresolved, unresolved_value_fields, missing_required = _field_kwargs(
model, record, resolver
model, record, resolver, tenant_required=tenant_required
)
if kwargs is None:
continue
+17
View File
@@ -0,0 +1,17 @@
from __future__ import annotations
def netbox_utilities_tenant_required() -> bool:
"""Return the effective tenant policy without requiring the optional plugin."""
try:
from netbox_utilities.runtime import tenant_required
except ImportError:
return False
return bool(tenant_required())
def relation_required_before_save(field, *, tenant_required: bool) -> bool:
if not tenant_required or field.name != "tenant":
return False
related_model = getattr(field.remote_field, "model", None)
return getattr(getattr(related_model, "_meta", None), "label_lower", None) == "tenancy.tenant"