settings to choose default tab types

app/lib/features/geckoview/domain/providers.dart

@@ -32,6 +32,7 @@ import 'package:weblibre/features/geckoview/domain/providers/selected_tab.dart';
 import 'package:weblibre/features/geckoview/domain/providers/tab_state.dart';
 import 'package:weblibre/features/geckoview/domain/repositories/tab.dart';
 import 'package:weblibre/features/geckoview/features/find_in_page/presentation/controllers/find_in_page.dart';
+import 'package:weblibre/features/user/domain/repositories/general_settings.dart';
 
 part 'providers.g.dart';
 
@@ -43,8 +44,11 @@ GeckoSelectionActionService selectionActionService(Ref ref) {
     service.setActions([
       SearchAction((text) async {
         final router = await ref.read(routerProvider.future);
+        final settings = ref.read(generalSettingsRepositoryProvider);
         final route = SearchRoute(
-          tabType: ref.read(selectedTabTypeProvider) ?? TabType.regular,
+          tabType:
+              ref.read(selectedTabTypeProvider) ??
+              settings.defaultCreateTabType,
           searchText: text,
         );
 
@@ -57,13 +61,19 @@ GeckoSelectionActionService selectionActionService(Ref ref) {
 
         if (defaultSearchBang != null) {
           final currentTab = ref.read(selectedTabStateProvider);
+          final isPrivate =
+              currentTab?.isPrivate ??
+              ref
+                      .read(generalSettingsRepositoryProvider)
+                      .defaultCreateTabType ==
+                  TabType.private;
 
           await ref
               .read(tabRepositoryProvider.notifier)
               .addTab(
                 url: defaultSearchBang.getTemplateUrl(text),
                 parentId: currentTab?.id,
-                private: currentTab?.isPrivate ?? false,
+                private: isPrivate,
               );
         } else {
           logger.e('No default search bang found');

app/lib/features/geckoview/domain/providers.g.dart

@@ -7,7 +7,7 @@ part of 'providers.dart';
 // **************************************************************************
 
 String _$selectionActionServiceHash() =>
-    r'ab6aeb105020a16ed24911acd73ba8553e5b3905';
+    r'f356434878b46fd443c8e3a8a48cf07c34a63b70';
 
 /// See also [selectionActionService].
 @ProviderFor(selectionActionService)

app/lib/features/geckoview/domain/repositories/tab.dart

@@ -25,6 +25,7 @@ import 'package:flutter_mozilla_components/flutter_mozilla_components.dart';
 import 'package:nullability/nullability.dart';
 import 'package:riverpod_annotation/riverpod_annotation.dart';
 import 'package:weblibre/core/logger.dart';
+import 'package:weblibre/core/routing/routes.dart';
 import 'package:weblibre/features/bangs/domain/providers/bangs.dart';
 import 'package:weblibre/features/geckoview/domain/entities/states/tab.dart';
 import 'package:weblibre/features/geckoview/domain/providers.dart';
@@ -38,6 +39,7 @@ import 'package:weblibre/features/geckoview/features/tabs/domain/providers/selec
 import 'package:weblibre/features/geckoview/features/tabs/domain/repositories/container.dart';
 import 'package:weblibre/features/geckoview/features/tabs/domain/repositories/tab.dart';
 import 'package:weblibre/features/share_intent/domain/entities/shared_content.dart';
+import 'package:weblibre/features/user/domain/repositories/general_settings.dart';
 import 'package:weblibre/utils/debouncer.dart';
 
 part 'tab.g.dart';
@@ -64,7 +66,7 @@ class TabRepository extends _$TabRepository {
     String? parentId,
     LoadUrlFlags flags = LoadUrlFlags.NONE,
     Source source = Internal.newTab,
-    bool private = false,
+    required bool private,
     HistoryMetadataKey? historyMetadata,
     Map<String, String>? additionalHeaders,
   }) async {
@@ -222,7 +224,7 @@ class TabRepository extends _$TabRepository {
     if (availableContainers.isNotEmpty) {
       //Last resort push new tab to avoid any authenticated tab is selected
       // ignore: avoid_redundant_argument_values
-      await addTab(selectTab: true);
+      await addTab(selectTab: true, private: false);
     }
   }
 
@@ -345,9 +347,17 @@ class TabRepository extends _$TabRepository {
       engineBoundIntentStreamProvider,
       (previous, next) {
         next.whenData((value) async {
+          final isPrivate =
+              ref
+                  .read(generalSettingsRepositoryProvider)
+                  .defaultIntentTabType ==
+              TabType.private;
+
           switch (value) {
             case SharedUrl():
-              _tabFromIntent.add(await addTab(url: value.url));
+              _tabFromIntent.add(
+                await addTab(url: value.url, private: isPrivate),
+              );
             case SharedText():
               final defaultSearchBang =
                   ref.read(selectedBangDataProvider()) ??
@@ -356,6 +366,7 @@ class TabRepository extends _$TabRepository {
               _tabFromIntent.add(
                 await addTab(
                   url: defaultSearchBang?.getTemplateUrl(value.text),
+                  private: isPrivate,
                 ),
               );
           }

app/lib/features/geckoview/domain/repositories/tab.g.dart

@@ -6,7 +6,7 @@ part of 'tab.dart';
 // RiverpodGenerator
 // **************************************************************************
 
-String _$tabRepositoryHash() => r'4b0dc3bbfd3635398009d655d811a4a35dbfb503';
+String _$tabRepositoryHash() => r'fccaa6521e1bad7e8b3f82e6d611469348dc8667';
 
 /// See also [TabRepository].
 @ProviderFor(TabRepository)