From ef2a3505a1c9f9fc610f7ece2de508456108f31a Mon Sep 17 00:00:00 2001 From: Fabian Freund Date: Fri, 28 Feb 2025 14:32:17 +0100 Subject: [PATCH] remove unnecessary override --- app/lib/data/models/drag_data.dart | 9 --------- app/lib/data/models/web_page_info.dart | 3 --- app/lib/features/bangs/data/models/bang.dart | 3 --- app/lib/features/bangs/data/models/bang_data.dart | 3 --- .../bangs/data/models/search_history_entry.dart | 3 --- .../chat_store/data/models/chat_metadata.dart | 3 --- .../geckoview/domain/entities/browser_icon.dart | 3 --- .../domain/entities/states/find_result.dart | 3 --- .../geckoview/domain/entities/states/history.dart | 6 ------ .../geckoview/domain/entities/states/readerable.dart | 3 --- .../geckoview/domain/entities/states/security.dart | 3 --- .../geckoview/domain/entities/states/tab.dart | 3 --- .../domain/entities/states/web_extension.dart | 3 --- .../features/browser/domain/entities/sheet.dart | 6 ------ .../preferences/data/models/preference_setting.dart | 6 ------ .../features/search/domain/entities/tab_preview.dart | 3 --- .../tabs/data/entities/container_filter.dart | 6 ------ .../features/tabs/data/models/container_data.dart | 12 ------------ .../features/tabs/data/models/tab_query_result.dart | 3 --- .../vector_store/data/models/vector_result.dart | 3 --- .../features/user/data/models/engine_settings.dart | 3 --- .../features/user/data/models/general_settings.dart | 3 --- .../features/web_feed/data/models/feed_article.dart | 3 --- .../data/models/feed_article_query_result.dart | 3 --- .../features/web_feed/data/models/feed_author.dart | 3 --- .../features/web_feed/data/models/feed_category.dart | 3 --- .../features/web_feed/data/models/feed_filter.dart | 3 --- app/lib/features/web_feed/data/models/feed_link.dart | 3 --- 28 files changed, 111 deletions(-) diff --git a/app/lib/data/models/drag_data.dart b/app/lib/data/models/drag_data.dart index 559dfb89..6a07cedc 100644 --- a/app/lib/data/models/drag_data.dart +++ b/app/lib/data/models/drag_data.dart @@ -7,9 +7,6 @@ final class ContainerDropData extends DropTargetData { ContainerDropData(this.tabId); - @override - bool get cacheHash => true; - @override List get hashParameters => [tabId]; } @@ -19,9 +16,6 @@ final class DeleteDropData extends DropTargetData { DeleteDropData(this.tabId); - @override - bool get cacheHash => true; - @override List get hashParameters => [tabId]; } @@ -33,9 +27,6 @@ final class TabDragData extends DragTargetData { TabDragData(this.tabId); - @override - bool get cacheHash => true; - @override List get hashParameters => [tabId]; } diff --git a/app/lib/data/models/web_page_info.dart b/app/lib/data/models/web_page_info.dart index d8e5f501..1ccfc733 100644 --- a/app/lib/data/models/web_page_info.dart +++ b/app/lib/data/models/web_page_info.dart @@ -17,9 +17,6 @@ class WebPageInfo with FastEquatable { WebPageInfo({required this.url, this.title, this.favicon, this.feeds}); - @override - bool get cacheHash => true; - @override List get hashParameters => [url, title, favicon, feeds]; } diff --git a/app/lib/features/bangs/data/models/bang.dart b/app/lib/features/bangs/data/models/bang.dart index c957dd72..0bbffc6c 100644 --- a/app/lib/features/bangs/data/models/bang.dart +++ b/app/lib/features/bangs/data/models/bang.dart @@ -113,9 +113,6 @@ class Bang with FastEquatable implements Insertable { Map toJson() => _$BangToJson(this); - @override - bool get cacheHash => true; - @override List get hashParameters => [ group, diff --git a/app/lib/features/bangs/data/models/bang_data.dart b/app/lib/features/bangs/data/models/bang_data.dart index 6bc4a93a..4bf84735 100644 --- a/app/lib/features/bangs/data/models/bang_data.dart +++ b/app/lib/features/bangs/data/models/bang_data.dart @@ -24,9 +24,6 @@ class BangData extends Bang { this.icon, }) : frequency = frequency ?? 0; - @override - bool get cacheHash => true; - @override List get hashParameters => [ ...super.hashParameters, diff --git a/app/lib/features/bangs/data/models/search_history_entry.dart b/app/lib/features/bangs/data/models/search_history_entry.dart index c6bafd78..ffb97f1c 100644 --- a/app/lib/features/bangs/data/models/search_history_entry.dart +++ b/app/lib/features/bangs/data/models/search_history_entry.dart @@ -11,9 +11,6 @@ class SearchHistoryEntry with FastEquatable { required this.searchDate, }); - @override - bool get cacheHash => true; - @override List get hashParameters => [searchQuery, trigger, searchDate]; } diff --git a/app/lib/features/chat/features/chat_store/data/models/chat_metadata.dart b/app/lib/features/chat/features/chat_store/data/models/chat_metadata.dart index da6a7252..e0d44ca5 100644 --- a/app/lib/features/chat/features/chat_store/data/models/chat_metadata.dart +++ b/app/lib/features/chat/features/chat_store/data/models/chat_metadata.dart @@ -15,9 +15,6 @@ class ChatMetadata with FastEquatable { Map toJson() => _$ChatMetadataToJson(this); - @override - bool get cacheHash => true; - @override List get hashParameters => [mainDocumentId, contextId]; } diff --git a/app/lib/features/geckoview/domain/entities/browser_icon.dart b/app/lib/features/geckoview/domain/entities/browser_icon.dart index c90161e2..db8ff133 100644 --- a/app/lib/features/geckoview/domain/entities/browser_icon.dart +++ b/app/lib/features/geckoview/domain/entities/browser_icon.dart @@ -32,9 +32,6 @@ class BrowserIcon with FastEquatable { required this.source, }); - @override - bool get cacheHash => true; - @override List get hashParameters => [image, dominantColor, source]; } diff --git a/app/lib/features/geckoview/domain/entities/states/find_result.dart b/app/lib/features/geckoview/domain/entities/states/find_result.dart index 70588786..8fa63760 100644 --- a/app/lib/features/geckoview/domain/entities/states/find_result.dart +++ b/app/lib/features/geckoview/domain/entities/states/find_result.dart @@ -23,7 +23,4 @@ class FindResultState with FastEquatable { numberOfMatches, isDoneCounting, ]; - - @override - bool get cacheHash => true; } diff --git a/app/lib/features/geckoview/domain/entities/states/history.dart b/app/lib/features/geckoview/domain/entities/states/history.dart index 93e759b6..84a24d86 100644 --- a/app/lib/features/geckoview/domain/entities/states/history.dart +++ b/app/lib/features/geckoview/domain/entities/states/history.dart @@ -6,9 +6,6 @@ class HistoryItem with FastEquatable { HistoryItem({required this.url, required this.title}); - @override - bool get cacheHash => true; - @override List get hashParameters => [url, title]; } @@ -34,9 +31,6 @@ class HistoryState with FastEquatable { canGoForward: false, ); - @override - bool get cacheHash => true; - @override List get hashParameters => [ items, diff --git a/app/lib/features/geckoview/domain/entities/states/readerable.dart b/app/lib/features/geckoview/domain/entities/states/readerable.dart index 6a3f2376..eda18866 100644 --- a/app/lib/features/geckoview/domain/entities/states/readerable.dart +++ b/app/lib/features/geckoview/domain/entities/states/readerable.dart @@ -10,9 +10,6 @@ class ReaderableState with FastEquatable { factory ReaderableState.$default() => ReaderableState(readerable: false, active: false); - @override - bool get cacheHash => true; - @override List get hashParameters => [readerable, active]; } diff --git a/app/lib/features/geckoview/domain/entities/states/security.dart b/app/lib/features/geckoview/domain/entities/states/security.dart index 3197de8b..b5b50eaf 100644 --- a/app/lib/features/geckoview/domain/entities/states/security.dart +++ b/app/lib/features/geckoview/domain/entities/states/security.dart @@ -14,9 +14,6 @@ class SecurityState with FastEquatable { factory SecurityState.$default() => SecurityState(secure: false, host: "", issuer: ""); - @override - bool get cacheHash => true; - @override List get hashParameters => [secure, host, issuer]; } diff --git a/app/lib/features/geckoview/domain/entities/states/tab.dart b/app/lib/features/geckoview/domain/entities/states/tab.dart index 437a37a0..2763a3e7 100644 --- a/app/lib/features/geckoview/domain/entities/states/tab.dart +++ b/app/lib/features/geckoview/domain/entities/states/tab.dart @@ -79,9 +79,6 @@ class TabState extends WebPageInfo { findResultState: FindResultState.$default(), ); - @override - bool get cacheHash => true; - @override List get hashParameters => [ ...super.hashParameters, diff --git a/app/lib/features/geckoview/domain/entities/states/web_extension.dart b/app/lib/features/geckoview/domain/entities/states/web_extension.dart index 1506e0d5..afa86ac7 100644 --- a/app/lib/features/geckoview/domain/entities/states/web_extension.dart +++ b/app/lib/features/geckoview/domain/entities/states/web_extension.dart @@ -28,9 +28,6 @@ class WebExtensionState with FastEquatable { this.icon, }); - @override - bool get cacheHash => true; - @override List get hashParameters => [ extensionId, diff --git a/app/lib/features/geckoview/features/browser/domain/entities/sheet.dart b/app/lib/features/geckoview/features/browser/domain/entities/sheet.dart index 7d967630..8f734cb6 100644 --- a/app/lib/features/geckoview/features/browser/domain/entities/sheet.dart +++ b/app/lib/features/geckoview/features/browser/domain/entities/sheet.dart @@ -3,9 +3,6 @@ import 'package:fast_equatable/fast_equatable.dart'; sealed class Sheet with FastEquatable {} final class ViewTabsSheet extends Sheet { - @override - bool get cacheHash => true; - @override List get hashParameters => [null]; } @@ -15,9 +12,6 @@ final class TabQaChatSheet extends Sheet { TabQaChatSheet({required this.chatId}); - @override - bool get cacheHash => true; - @override List get hashParameters => [chatId]; } diff --git a/app/lib/features/geckoview/features/preferences/data/models/preference_setting.dart b/app/lib/features/geckoview/features/preferences/data/models/preference_setting.dart index c4cccb98..2e08c208 100644 --- a/app/lib/features/geckoview/features/preferences/data/models/preference_setting.dart +++ b/app/lib/features/geckoview/features/preferences/data/models/preference_setting.dart @@ -18,9 +18,6 @@ class PreferenceSettingGroup with FastEquatable { PreferenceSettingGroup({required this.description, required this.settings}); - @override - bool get cacheHash => true; - @override List get hashParameters => [description, settings]; } @@ -55,9 +52,6 @@ class PreferenceSetting with FastEquatable { Map toJson() => _$PreferenceSettingToJson(this); - @override - bool get cacheHash => true; - @override List get hashParameters => [ value, diff --git a/app/lib/features/geckoview/features/search/domain/entities/tab_preview.dart b/app/lib/features/geckoview/features/search/domain/entities/tab_preview.dart index 086bb936..91f07deb 100644 --- a/app/lib/features/geckoview/features/search/domain/entities/tab_preview.dart +++ b/app/lib/features/geckoview/features/search/domain/entities/tab_preview.dart @@ -30,7 +30,4 @@ class TabPreview with FastEquatable { highlightedUrl, content, ]; - - @override - bool get cacheHash => true; } diff --git a/app/lib/features/geckoview/features/tabs/data/entities/container_filter.dart b/app/lib/features/geckoview/features/tabs/data/entities/container_filter.dart index 81969513..509a4a9c 100644 --- a/app/lib/features/geckoview/features/tabs/data/entities/container_filter.dart +++ b/app/lib/features/geckoview/features/tabs/data/entities/container_filter.dart @@ -7,17 +7,11 @@ class ContainerFilterById extends ContainerFilter { ContainerFilterById({required this.containerId}); - @override - bool get cacheHash => true; - @override List get hashParameters => [containerId]; } class ContainerFilterDisabled extends ContainerFilter { - @override - bool get cacheHash => true; - @override List get hashParameters => [null]; } diff --git a/app/lib/features/geckoview/features/tabs/data/models/container_data.dart b/app/lib/features/geckoview/features/tabs/data/models/container_data.dart index 3b7a6699..25468653 100644 --- a/app/lib/features/geckoview/features/tabs/data/models/container_data.dart +++ b/app/lib/features/geckoview/features/tabs/data/models/container_data.dart @@ -40,9 +40,6 @@ class ContainerAuthSettings with FastEquatable { lockOnAppBackground, lockTimeout, ]; - - @override - bool get cacheHash => true; } @CopyWith() @@ -87,9 +84,6 @@ class ContainerMetadata with FastEquatable { authSettings, useProxy, ]; - - @override - bool get cacheHash => true; } @CopyWith() @@ -106,9 +100,6 @@ class ContainerData with FastEquatable { ContainerMetadata? metadata, }) : metadata = metadata ?? ContainerMetadata.withDefaults(); - @override - bool get cacheHash => true; - @override List get hashParameters => [id, name, color, metadata]; } @@ -124,9 +115,6 @@ class ContainerDataWithCount extends ContainerData { required this.tabCount, }); - @override - bool get cacheHash => true; - @override List get hashParameters => [...super.hashParameters, tabCount]; } diff --git a/app/lib/features/geckoview/features/tabs/data/models/tab_query_result.dart b/app/lib/features/geckoview/features/tabs/data/models/tab_query_result.dart index b592e055..62aecb0f 100644 --- a/app/lib/features/geckoview/features/tabs/data/models/tab_query_result.dart +++ b/app/lib/features/geckoview/features/tabs/data/models/tab_query_result.dart @@ -22,9 +22,6 @@ class TabQueryResult with FastEquatable { required this.weightedRank, }); - @override - bool get cacheHash => true; - @override List get hashParameters => [ id, diff --git a/app/lib/features/geckoview/features/tabs/features/vector_store/data/models/vector_result.dart b/app/lib/features/geckoview/features/tabs/features/vector_store/data/models/vector_result.dart index 5eb61de8..f71398b9 100644 --- a/app/lib/features/geckoview/features/tabs/features/vector_store/data/models/vector_result.dart +++ b/app/lib/features/geckoview/features/tabs/features/vector_store/data/models/vector_result.dart @@ -28,9 +28,6 @@ class VectorResult with FastEquatable { return Document(id: id, pageContent: content, metadata: metadata); } - @override - bool get cacheHash => true; - @override List get hashParameters => [ id, diff --git a/app/lib/features/user/data/models/engine_settings.dart b/app/lib/features/user/data/models/engine_settings.dart index 0cb0733c..c32428f4 100644 --- a/app/lib/features/user/data/models/engine_settings.dart +++ b/app/lib/features/user/data/models/engine_settings.dart @@ -85,9 +85,6 @@ class EngineSettings extends GeckoEngineSettings with FastEquatable { Map toJson() => _$EngineSettingsToJson(this); - @override - bool get cacheHash => true; - @override List get hashParameters => [ super.javascriptEnabled, diff --git a/app/lib/features/user/data/models/general_settings.dart b/app/lib/features/user/data/models/general_settings.dart index d02b2a5f..89b2a487 100644 --- a/app/lib/features/user/data/models/general_settings.dart +++ b/app/lib/features/user/data/models/general_settings.dart @@ -44,9 +44,6 @@ class GeneralSettings with FastEquatable { Map toJson() => _$GeneralSettingsToJson(this); - @override - bool get cacheHash => true; - @override List get hashParameters => [ themeMode, diff --git a/app/lib/features/web_feed/data/models/feed_article.dart b/app/lib/features/web_feed/data/models/feed_article.dart index f1ca4895..f1361dbd 100644 --- a/app/lib/features/web_feed/data/models/feed_article.dart +++ b/app/lib/features/web_feed/data/models/feed_article.dart @@ -93,9 +93,6 @@ class FeedArticle with FastEquatable implements Insertable { return map; } - @override - bool get cacheHash => true; - @override List get hashParameters => [ id, diff --git a/app/lib/features/web_feed/data/models/feed_article_query_result.dart b/app/lib/features/web_feed/data/models/feed_article_query_result.dart index 2f6cc8a9..30724f14 100644 --- a/app/lib/features/web_feed/data/models/feed_article_query_result.dart +++ b/app/lib/features/web_feed/data/models/feed_article_query_result.dart @@ -21,9 +21,6 @@ class FeedArticleQueryResult extends FeedArticle { super.contentPlain, }); - @override - bool get cacheHash => true; - @override List get hashParameters => [...super.hashParameters, weightedRank]; } diff --git a/app/lib/features/web_feed/data/models/feed_author.dart b/app/lib/features/web_feed/data/models/feed_author.dart index aa33b696..0a64e2e9 100644 --- a/app/lib/features/web_feed/data/models/feed_author.dart +++ b/app/lib/features/web_feed/data/models/feed_author.dart @@ -15,9 +15,6 @@ class FeedAuthor with FastEquatable { Map toJson() => _$FeedAuthorToJson(this); - @override - bool get cacheHash => true; - @override List get hashParameters => [name, email]; } diff --git a/app/lib/features/web_feed/data/models/feed_category.dart b/app/lib/features/web_feed/data/models/feed_category.dart index 3f6aa987..e16331ec 100644 --- a/app/lib/features/web_feed/data/models/feed_category.dart +++ b/app/lib/features/web_feed/data/models/feed_category.dart @@ -15,9 +15,6 @@ class FeedCategory with FastEquatable { Map toJson() => _$FeedCategoryToJson(this); - @override - bool get cacheHash => true; - @override List get hashParameters => [id, title]; } diff --git a/app/lib/features/web_feed/data/models/feed_filter.dart b/app/lib/features/web_feed/data/models/feed_filter.dart index f7a384cd..b64ef170 100644 --- a/app/lib/features/web_feed/data/models/feed_filter.dart +++ b/app/lib/features/web_feed/data/models/feed_filter.dart @@ -11,9 +11,6 @@ class FeedFilter with FastEquatable { FeedFilter({this.feedId, this.query, this.tags}); - @override - bool get cacheHash => true; - @override List get hashParameters => [feedId, query, tags]; } diff --git a/app/lib/features/web_feed/data/models/feed_link.dart b/app/lib/features/web_feed/data/models/feed_link.dart index 0391b32a..3228c7ba 100644 --- a/app/lib/features/web_feed/data/models/feed_link.dart +++ b/app/lib/features/web_feed/data/models/feed_link.dart @@ -33,9 +33,6 @@ class FeedLink with FastEquatable { Map toJson() => _$FeedLinkToJson(this); - @override - bool get cacheHash => true; - @override List get hashParameters => [uri, relation, title]; }