MrBlake/MrbWebLibre
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

change favicon loading

Browse Source
This commit is contained in:
Fabian Freund
2024-06-15 17:06:53 +02:00
parent cf8541024d
commit e2b2a46733
2 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/lib/features/web_view/presentation/widgets/favicon.dart
+6 -1
View File
@@ -27,7 +27,12 @@ class FaviconImage extends StatelessWidget {
), ),
image: NetworkImage(webPageInfo.favicon!.url.toString()), image: NetworkImage(webPageInfo.favicon!.url.toString()),
placeholderErrorBuilder: (_, __, ___) => _iconPlaceholder, placeholderErrorBuilder: (_, __, ___) => _iconPlaceholder,
imageErrorBuilder: (_, __, ___) => _iconPlaceholder, imageErrorBuilder: (_, __, ___) => Image.network(
webPageInfo.url.genericFavicon().toString(),
errorBuilder: (_, __, ___) => _iconPlaceholder,
height: size,
width: size,
),
height: size, height: size,
width: size, width: size,
); );
app/lib/features/web_view/presentation/widgets/web_view.dart
+4 -5
View File
@@ -12,7 +12,6 @@ import 'package:bang_navigator/features/web_view/domain/entities/web_view_page.d
import 'package:bang_navigator/features/web_view/presentation/controllers/switch_new_tab.dart'; import 'package:bang_navigator/features/web_view/presentation/controllers/switch_new_tab.dart';
import 'package:bang_navigator/features/web_view/presentation/widgets/web_page_dialog.dart'; import 'package:bang_navigator/features/web_view/presentation/widgets/web_page_dialog.dart';
import 'package:bang_navigator/features/web_view/utils/download_helper.dart'; import 'package:bang_navigator/features/web_view/utils/download_helper.dart';
import 'package:bang_navigator/features/web_view/utils/favicon_helper.dart';
import 'package:bang_navigator/utils/platform_util.dart' as platform_util; import 'package:bang_navigator/utils/platform_util.dart' as platform_util;
import 'package:bang_navigator/utils/ui_helper.dart' as ui_helper; import 'package:bang_navigator/utils/ui_helper.dart' as ui_helper;
import 'package:flutter/foundation.dart'; import 'package:flutter/foundation.dart';
@@ -241,10 +240,10 @@ class _WebViewState extends ConsumerState<WebView> {
_onLoadStopDebounce?.cancel(); _onLoadStopDebounce?.cancel();
_onLoadStopDebounce = _onLoadStopDebounce =
Timer(const Duration(milliseconds: 150), () async { Timer(const Duration(milliseconds: 150), () async {
final favicon = await widget.page.value.controller // final favicon = await widget.page.value.controller
?.getFavicons() // ?.getFavicons()
.then((icons) => choseFavicon(icons)); // .then((icons) => choseFavicon(icons));
widget.updatePage((page) => page.copyWith.favicon(favicon)); // widget.updatePage((page) => page.copyWith.favicon(favicon));
await _updateScreenshot().whenComplete(() { await _updateScreenshot().whenComplete(() {
_periodicScreenshotUpdate?.cancel(); _periodicScreenshotUpdate?.cancel();