MrBlake/MrbWebLibre
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

improved error logging and handling

Browse Source
This commit is contained in:
Fabian Freund
2026-01-21 11:07:23 +01:00
parent f648c43441
commit dc4a5a9c85
35 changed files with 242 additions and 115 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/lib/features/geckoview/domain/providers/selected_tab.dart
+8 -3
View File
@@ -47,9 +47,14 @@ class SelectedTab extends _$SelectedTab {
},
);
final selectedTabSub = eventSerivce.selectedTabEvents.listen((tabId) {
state = tabId;
});
final selectedTabSub = eventSerivce.selectedTabEvents.listen(
(tabId) {
state = tabId;
},
onError: (Object error, StackTrace stackTrace) {
logger.e('Error in selected tab events', error: error, stackTrace: stackTrace);
},
);
ref.onDispose(() async {
await selectedTabSub.cancel();
app/lib/features/geckoview/domain/providers/selected_tab.g.dart
+1 -1
View File
@@ -41,7 +41,7 @@ final class SelectedTabProvider
}
}
String _$selectedTabHash() => r'26d1bb90c777d7011f4f27f7b962584a4a62a0a7';
String _$selectedTabHash() => r'5caa359376e9103767e2d2e94c548d53cba79d0f';
abstract class _$SelectedTab extends $Notifier<String?> {
String? build();
app/lib/features/geckoview/domain/providers/tab_list.dart
+11 -6
View File
@@ -48,13 +48,18 @@ class TabList extends _$TabList {
},
);
final tabListSub = eventService.tabListEvents.listen((tabs) {
final equatableTabs = EquatableValue(tabs);
final tabListSub = eventService.tabListEvents.listen(
(tabs) {
final equatableTabs = EquatableValue(tabs);
if (equatableTabs != state) {
state = equatableTabs;
}
});
if (equatableTabs != state) {
state = equatableTabs;
}
},
onError: (Object error, StackTrace stackTrace) {
logger.e('Error in tab list events', error: error, stackTrace: stackTrace);
},
);
ref.onDispose(() async {
await tabListSub.cancel();
app/lib/features/geckoview/domain/providers/tab_list.g.dart
+1 -1
View File
@@ -41,7 +41,7 @@ final class TabListProvider
}
}
String _$tabListHash() => r'0b9ca1e089a59895df4cbf28691c2849a7004f08';
String _$tabListHash() => r'88c2598a4d586fee9e3d0f1b418cf88ea5c7da75';
abstract class _$TabList extends $Notifier<EquatableValue<List<String>>> {
EquatableValue<List<String>> build();
app/lib/features/geckoview/domain/providers/tab_state.dart
+56 -21
View File
@@ -218,29 +218,64 @@ class TabStates extends _$TabStates {
final eventService = ref.watch(eventServiceProvider);
final subscriptions = [
eventService.tabContentEvents.listen((event) async {
await _onTabContentStateChange(event);
}),
eventService.iconChangeEvents.listen((event) async {
await _onIconChange(event);
}),
eventService.thumbnailEvents.listen((event) async {
await _onThumbnailChange(event);
}),
eventService.securityInfoEvents.listen((event) {
_onSecurityInfoStateChange(event);
}),
eventService.historyEvents.listen((event) {
_onHistoryStateChange(event);
}),
eventService.readerableEvents.listen((event) {
_onReaderableStateChange(event);
}),
eventService.tabContentEvents.listen(
(event) async {
await _onTabContentStateChange(event);
},
onError: (Object error, StackTrace stackTrace) {
logger.e('Error in tab content events', error: error, stackTrace: stackTrace);
},
),
eventService.iconChangeEvents.listen(
(event) async {
await _onIconChange(event);
},
onError: (Object error, StackTrace stackTrace) {
logger.e('Error in icon change events', error: error, stackTrace: stackTrace);
},
),
eventService.thumbnailEvents.listen(
(event) async {
await _onThumbnailChange(event);
},
onError: (Object error, StackTrace stackTrace) {
logger.e('Error in thumbnail events', error: error, stackTrace: stackTrace);
},
),
eventService.securityInfoEvents.listen(
(event) {
_onSecurityInfoStateChange(event);
},
onError: (Object error, StackTrace stackTrace) {
logger.e('Error in security info events', error: error, stackTrace: stackTrace);
},
),
eventService.historyEvents.listen(
(event) {
_onHistoryStateChange(event);
},
onError: (Object error, StackTrace stackTrace) {
logger.e('Error in history events', error: error, stackTrace: stackTrace);
},
),
eventService.readerableEvents.listen(
(event) {
_onReaderableStateChange(event);
},
onError: (Object error, StackTrace stackTrace) {
logger.e('Error in readerable events', error: error, stackTrace: stackTrace);
},
),
eventService.findResultsEvent
.debounceTime(const Duration(milliseconds: 25))
.listen((event) {
_onFindResultsChange(event);
}),
.listen(
(event) {
_onFindResultsChange(event);
},
onError: (Object error, StackTrace stackTrace) {
logger.e('Error in find results events', error: error, stackTrace: stackTrace);
},
),
];
ref.listen(
app/lib/features/geckoview/domain/providers/tab_state.g.dart
+1 -1
View File
@@ -41,7 +41,7 @@ final class TabStatesProvider
}
}
String _$tabStatesHash() => r'67b497304b4137ce0115a66f06f3622c86e5727d';
String _$tabStatesHash() => r'985d2eb87c59c3a113b8bbcf9d96267c42a2f543';
abstract class _$TabStates extends $Notifier<Map<String, TabState>> {
Map<String, TabState> build();
app/lib/features/geckoview/domain/providers/web_extensions_state.dart
+33 -12
View File
@@ -23,6 +23,7 @@ import 'dart:ui';
import 'package:flutter_mozilla_components/flutter_mozilla_components.dart';
import 'package:nullability/nullability.dart';
import 'package:riverpod_annotation/riverpod_annotation.dart';
import 'package:weblibre/core/logger.dart';
import 'package:weblibre/domain/entities/equatable_image.dart';
import 'package:weblibre/features/geckoview/domain/entities/states/web_extension.dart';
import 'package:weblibre/features/geckoview/domain/providers.dart';
@@ -100,20 +101,40 @@ class WebExtensionsState extends _$WebExtensionsState {
final subscriptions = switch (actionType) {
WebExtensionActionType.browser => [
addonService.browserExtensionStream.listen((event) {
_onExtensionUpdate(event);
}),
addonService.browserIconStream.listen((event) async {
await _onIconChange(event);
}),
addonService.browserExtensionStream.listen(
(event) {
_onExtensionUpdate(event);
},
onError: (Object error, StackTrace stackTrace) {
logger.e('Error in browser extension stream', error: error, stackTrace: stackTrace);
},
),
addonService.browserIconStream.listen(
(event) async {
await _onIconChange(event);
},
onError: (Object error, StackTrace stackTrace) {
logger.e('Error in browser icon stream', error: error, stackTrace: stackTrace);
},
),
],
WebExtensionActionType.page => [
addonService.pageExtensionStream.listen((event) {
_onExtensionUpdate(event);
}),
addonService.pageIconStream.listen((event) async {
await _onIconChange(event);
}),
addonService.pageExtensionStream.listen(
(event) {
_onExtensionUpdate(event);
},
onError: (Object error, StackTrace stackTrace) {
logger.e('Error in page extension stream', error: error, stackTrace: stackTrace);
},
),
addonService.pageIconStream.listen(
(event) async {
await _onIconChange(event);
},
onError: (Object error, StackTrace stackTrace) {
logger.e('Error in page icon stream', error: error, stackTrace: stackTrace);
},
),
],
};
app/lib/features/geckoview/domain/providers/web_extensions_state.g.dart
+1 -1
View File
@@ -62,7 +62,7 @@ final class WebExtensionsStateProvider
}
String _$webExtensionsStateHash() =>
r'2664a50bb776197010e9da9b4e3a9379c849ba75';
r'd74f739a2f33395c10e30a81c8031f2f2630e418';
final class WebExtensionsStateFamily extends $Family
with
app/lib/features/geckoview/domain/repositories/tab.dart
+38 -26
View File
@@ -424,16 +424,21 @@ class TabRepository extends _$TabRepository {
final db = ref.watch(tabDatabaseProvider);
final tabAddedSub = eventSerivce.tabAddedStream.listen((tabId) async {
final containerId = ref.read(selectedContainerProvider);
await db.tabDao.insertTab(
tabId,
parentId: const Value.absent(),
source: TabSource.addedEvent,
containerId: Value(containerId),
isPrivate: const Value.absent(),
);
});
final tabAddedSub = eventSerivce.tabAddedStream.listen(
(tabId) async {
final containerId = ref.read(selectedContainerProvider);
await db.tabDao.insertTab(
tabId,
parentId: const Value.absent(),
source: TabSource.addedEvent,
containerId: Value(containerId),
isPrivate: const Value.absent(),
);
},
onError: (Object error, StackTrace stackTrace) {
logger.e('Error in tab added stream', error: error, stackTrace: stackTrace);
},
);
final containerSiteAssignementSub = eventSerivce.siteAssignementEvent.listen((
event,
@@ -522,20 +527,27 @@ class TabRepository extends _$TabRepository {
logger.w('Could not get tab for assignement ${tabState?.url}');
}
}
});
},
onError: (Object error, StackTrace stackTrace) {
logger.e('Error in container site assignment stream', error: error, stackTrace: stackTrace);
},
);
final tabContentSub = tabContentService.tabContentStream.listen((
content,
) async {
await db.tabDao.updateTabContent(
content.tabId,
isProbablyReaderable: content.isProbablyReaderable,
extractedContentMarkdown: content.extractedContentMarkdown,
extractedContentPlain: content.extractedContentPlain,
fullContentMarkdown: content.fullContentMarkdown,
fullContentPlain: content.fullContentPlain,
);
});
final tabContentSub = tabContentService.tabContentStream.listen(
(content) async {
await db.tabDao.updateTabContent(
content.tabId,
isProbablyReaderable: content.isProbablyReaderable,
extractedContentMarkdown: content.extractedContentMarkdown,
extractedContentPlain: content.extractedContentPlain,
fullContentMarkdown: content.fullContentMarkdown,
fullContentPlain: content.fullContentPlain,
);
},
onError: (Object error, StackTrace stackTrace) {
logger.e('Error in tab content stream', error: error, stackTrace: stackTrace);
},
);
ref.listen(
fireImmediately: true,
@@ -545,7 +557,7 @@ class TabRepository extends _$TabRepository {
await db.tabDao.touchTab(tabId, timestamp: DateTime.now());
}
},
onError: (error, stackTrace) {
onError: (Object error, StackTrace stackTrace) {
logger.e(
'Error listening to selectedTabProvider',
error: error,
@@ -565,7 +577,7 @@ class TabRepository extends _$TabRepository {
await db.tabDao.syncTabs(retainTabIds: next.value);
}
},
onError: (error, stackTrace) {
onError: (Object error, StackTrace stackTrace) {
logger.e(
'Error listening to tabListProvider',
error: error,
@@ -591,7 +603,7 @@ class TabRepository extends _$TabRepository {
await db.tabDao.updateTabs(debounceStartValue, next);
});
},
onError: (error, stackTrace) {
onError: (Object error, StackTrace stackTrace) {
logger.e(
'Error listening to tabStatesProvider',
error: error,
app/lib/features/geckoview/domain/repositories/tab.g.dart
+1 -1
View File
@@ -41,7 +41,7 @@ final class TabRepositoryProvider
}
}
String _$tabRepositoryHash() => r'763f5ea734abc854dfdc0c08d3f266fbd94bf931';
String _$tabRepositoryHash() => r'ff8ce73a65d408587cfb41e1920332d15ddff55f';
abstract class _$TabRepository extends $Notifier<void> {
void build();
app/lib/features/geckoview/features/bookmarks/presentation/screens/bookmark_list.dart
+5 -2
View File
@@ -29,6 +29,7 @@ import 'package:flutter_material_design_icons/flutter_material_design_icons.dart
import 'package:flutter_mozilla_components/flutter_mozilla_components.dart';
import 'package:hooks_riverpod/hooks_riverpod.dart';
import 'package:nullability/nullability.dart';
import 'package:weblibre/core/logger.dart';
import 'package:weblibre/core/routing/routes.dart';
import 'package:weblibre/features/geckoview/features/bookmarks/domain/entities/bookmark_item.dart';
import 'package:weblibre/features/geckoview/features/bookmarks/domain/providers/bookmarks.dart';
@@ -405,7 +406,8 @@ class BookmarkListScreen extends HookConsumerWidget {
if (context.mounted) {
showInfoMessage(context, 'Imported $count bookmarks successfully');
}
} catch (e) {
} catch (e, s) {
logger.e('Bookmark import failed', error: e, stackTrace: s);
if (context.mounted) {
showErrorMessage(context, 'Import failed: $e');
}
@@ -454,7 +456,8 @@ class BookmarkListScreen extends HookConsumerWidget {
if (context.mounted) {
showInfoMessage(context, 'Bookmarks exported successfully');
}
} catch (e) {
} catch (e, s) {
logger.e('Bookmark export failed', error: e, stackTrace: s);
if (context.mounted) {
showErrorMessage(context, 'Export failed: $e');
}
app/lib/features/geckoview/features/browser/domain/providers/intent.dart
+5 -1
View File
@@ -22,6 +22,7 @@ import 'dart:async';
import 'package:nullability/nullability.dart';
import 'package:riverpod_annotation/riverpod_annotation.dart';
import 'package:rxdart/rxdart.dart';
import 'package:weblibre/core/logger.dart';
import 'package:weblibre/core/routing/routes.dart';
import 'package:weblibre/data/models/received_intent_parameter.dart';
import 'package:weblibre/features/app_widget/domain/services/home_widget.dart';
@@ -67,7 +68,10 @@ class EngineBoundIntentStream extends _$EngineBoundIntentStream {
appWidgetLaunchStream.transform(_contentParserTransformer),
]).listen(
controller.add,
onError: controller.addError,
onError: (Object error, StackTrace stackTrace) {
logger.e('Intent stream error', error: error, stackTrace: stackTrace);
controller.addError(error, stackTrace);
},
onDone: controller.close,
);
app/lib/features/geckoview/features/browser/domain/providers/intent.g.dart
+1 -1
View File
@@ -34,7 +34,7 @@ final class EngineBoundIntentStreamProvider
}
String _$engineBoundIntentStreamHash() =>
r'ab9804f97e0222b2306683d2fcfa71d3d57ecd21';
r'618eb6431da93989de6f1780cba2993458b0014e';
abstract class _$EngineBoundIntentStream
extends $StreamNotifier<SharedContent> {
app/lib/features/geckoview/features/browser/presentation/widgets/browser_modules/browser_view.dart
+1 -1
View File
@@ -302,7 +302,7 @@ class _BrowserViewState extends ConsumerState<BrowserView>
await router.push(route.location);
} else {
throw UnimplementedError();
throw UnimplementedError('Unknown quick action shortcut type');
}
}
});
app/lib/features/geckoview/features/browser/presentation/widgets/sheets/clear_site_data_section.dart
+3 -1
View File
@@ -21,6 +21,7 @@ import 'package:flutter/material.dart';
import 'package:flutter_hooks/flutter_hooks.dart';
import 'package:flutter_mozilla_components/flutter_mozilla_components.dart';
import 'package:hooks_riverpod/hooks_riverpod.dart';
import 'package:weblibre/core/logger.dart';
import 'package:weblibre/features/geckoview/domain/providers/tab_session.dart';
import 'package:weblibre/features/geckoview/features/browser/presentation/dialogs/clear_site_data_dialog.dart';
import 'package:weblibre/utils/ui_helper.dart';
@@ -163,7 +164,8 @@ class ClearSiteDataSection extends HookConsumerWidget {
if (context.mounted) {
showInfoMessage(context, 'Site data cleared');
}
} catch (e) {
} catch (e, s) {
logger.e('Failed to clear site data', error: e, stackTrace: s);
if (context.mounted) {
showErrorMessage(context, 'Failed to clear site data: $e');
}
app/lib/features/geckoview/features/browser/presentation/widgets/sheets/tracking_protection_section.dart
+3 -1
View File
@@ -20,6 +20,7 @@
import 'package:flutter/material.dart';
import 'package:hooks_riverpod/hooks_riverpod.dart';
import 'package:skeletonizer/skeletonizer.dart';
import 'package:weblibre/core/logger.dart';
import 'package:weblibre/features/geckoview/domain/providers/tab_session.dart';
import 'package:weblibre/features/geckoview/features/browser/domain/repositories/tracking_protection.dart';
import 'package:weblibre/features/geckoview/features/browser/presentation/widgets/sheets/tracking_protection_provider.dart';
@@ -102,7 +103,8 @@ class _TrackingProtectionTile extends ConsumerWidget {
// Reload tab to apply changes
await ref.read(selectedTabSessionProvider).reload();
} catch (e) {
} catch (e, s) {
logger.e('Failed to toggle tracking protection', error: e, stackTrace: s);
if (context.mounted) {
showErrorMessage(context, 'Failed to toggle tracking protection: $e');
}
app/lib/features/geckoview/features/browser/presentation/widgets/tab_view/tab_grid_view.dart
+1 -1
View File
@@ -82,7 +82,7 @@ class _TabDraggable extends HookConsumerWidget {
sourceSearchQuery: switch (entity) {
DefaultTabEntity _ => null,
final SearchResultTabEntity entity => entity.searchQuery,
TabTreeEntity _ => throw UnimplementedError(),
TabTreeEntity _ => throw UnimplementedError('TabTreeEntity not implemented in tab grid view'),
},
);
}, [entity.tabId, activeTab, suggestedContainerId]);
app/lib/features/geckoview/features/browser/presentation/widgets/tab_view/tab_list_view.dart
+1 -1
View File
@@ -83,7 +83,7 @@ class _TabDraggable extends HookConsumerWidget {
sourceSearchQuery: switch (entity) {
DefaultTabEntity _ => null,
final SearchResultTabEntity entity => entity.searchQuery,
TabTreeEntity _ => throw UnimplementedError(),
TabTreeEntity _ => throw UnimplementedError('TabTreeEntity not implemented in tab list view'),
},
);
}, [entity.tabId, activeTab, suggestedContainerId]);
app/lib/features/geckoview/features/browser/presentation/widgets/tab_view/tab_view_header.dart
+3 -1
View File
@@ -7,6 +7,7 @@ import 'package:flutter_hooks/flutter_hooks.dart';
import 'package:flutter_material_design_icons/flutter_material_design_icons.dart';
import 'package:flutter_mozilla_components/flutter_mozilla_components.dart';
import 'package:hooks_riverpod/hooks_riverpod.dart';
import 'package:weblibre/core/logger.dart';
import 'package:weblibre/core/routing/routes.dart';
import 'package:weblibre/features/geckoview/domain/providers.dart';
import 'package:weblibre/features/geckoview/domain/repositories/tab.dart';
@@ -484,7 +485,8 @@ class TabViewHeader extends HookConsumerWidget {
: 'Container data cleared. ${tabs.length} tab(s) closed.',
);
}
} catch (e) {
} catch (e, s) {
logger.e('Failed to clear container data', error: e, stackTrace: s);
if (context.mounted) {
ui_helper.showErrorMessage(
context,
app/lib/features/geckoview/features/history/presentation/screens/history.dart
+2 -2
View File
@@ -171,7 +171,7 @@ class Section extends MultiSliver {
VisitType.download => const Text('Download'),
VisitType.framedLink => const Text('Frame'),
VisitType.reload => const Text('Page Reload'),
VisitType.bookmark => throw UnimplementedError(),
VisitType.bookmark => throw UnimplementedError('VisitType.bookmark chip display not implemented'),
},
),
Chip(
@@ -374,7 +374,7 @@ class HistoryScreen extends HookConsumerWidget {
VisitType.download => const Text('Downloads'),
VisitType.framedLink => const Text('Frames'),
VisitType.reload => const Text('Page Reloads'),
VisitType.bookmark => throw UnimplementedError(),
VisitType.bookmark => throw UnimplementedError('VisitType.bookmark filter not implemented'),
},
),
),
app/lib/features/geckoview/utils/image_helper.dart
+3 -2
View File
@@ -21,6 +21,7 @@ import 'dart:typed_data';
import 'dart:ui';
import 'package:fast_equatable/hash.dart';
import 'package:weblibre/core/logger.dart';
import 'package:weblibre/domain/entities/equatable_image.dart';
import 'package:weblibre/utils/lru_cache.dart';
@@ -64,8 +65,8 @@ Future<EquatableImage?> tryDecodeImage(
_cache.set(digest, image);
return image;
}
} catch (e) {
//swallow
} catch (e, s) {
logger.w('Failed to decode image', error: e, stackTrace: s);
}
return null;