From ce0ec8813ca3110923305c9f69220affe9a860f0 Mon Sep 17 00:00:00 2001
From: Fabian Freund <github@fabi.online>
Date: Fri, 31 Oct 2025 14:17:25 +0100
Subject: [PATCH] fix and improve icon caching

---
 app/lib/domain/services/generic_website.dart | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/app/lib/domain/services/generic_website.dart b/app/lib/domain/services/generic_website.dart
index 15e225f9..edcee6f7 100644
--- a/app/lib/domain/services/generic_website.dart
+++ b/app/lib/domain/services/generic_website.dart
@@ -291,7 +291,7 @@ class GenericWebsiteService extends _$GenericWebsiteService {
   }
 
   Future<BrowserIcon?> getCachedIcon(Uri url) async {
-    if (url.scheme.startsWith('http')) {
+    if (url.scheme.startsWith('https') || url.scheme.startsWith('http')) {
       final cachedBrowserIcon = _browserIconCache.get(url.origin);
       if (cachedBrowserIcon != null) {
         return cachedBrowserIcon;
@@ -326,7 +326,10 @@ class GenericWebsiteService extends _$GenericWebsiteService {
       waitOnNetworkLoad: waitOnNetworkLoad,
     );
 
-    // unawaited(_cacheRepository.cacheIcon(url, result.image));
+    if (result.source != IconSource.generator &&
+        result.source != IconSource.memory) {
+      await _cacheRepository.cacheIcon(url, result.image);
+    }
 
     return _browserIconCache.set(
       url.origin,