extended logging for bottom sheet with unique keys

This commit is contained in:
Fabian Freund
2025-12-11 06:54:12 +01:00
parent a18fc8ba7d
commit c7903bcfe8
@@ -25,6 +25,7 @@ import 'package:flutter/services.dart';
import 'package:flutter_hooks/flutter_hooks.dart'; import 'package:flutter_hooks/flutter_hooks.dart';
import 'package:go_router/go_router.dart'; import 'package:go_router/go_router.dart';
import 'package:hooks_riverpod/hooks_riverpod.dart'; import 'package:hooks_riverpod/hooks_riverpod.dart';
import 'package:weblibre/core/logger.dart';
import 'package:weblibre/core/providers/global_drop.dart'; import 'package:weblibre/core/providers/global_drop.dart';
import 'package:weblibre/core/routing/routes.dart'; import 'package:weblibre/core/routing/routes.dart';
import 'package:weblibre/data/models/drag_data.dart'; import 'package:weblibre/data/models/drag_data.dart';
@@ -251,38 +252,61 @@ class _Browser extends HookConsumerWidget {
final overlayBuilder = ref.watch(overlayControllerProvider); final overlayBuilder = ref.watch(overlayControllerProvider);
ref.listen(bottomSheetControllerProvider, (previous, next) { ref.listen(bottomSheetControllerProvider, (previous, next) {
if (!context.mounted) {
logger.e('Cannot show sheet, context not mounted');
return;
}
WidgetsBinding.instance.addPostFrameCallback((_) {
if (!context.mounted) {
logger.e('Cannot show sheet, context not mounted (post frame)');
return;
}
// Close existing sheet
if (sheetController.value != null) { if (sheetController.value != null) {
try { try {
sheetController.value!.close(); final existingController = sheetController.value!;
} catch (_) { sheetController.value = null;
//silently drop closing errors existingController.close();
} catch (e) {
logger.e('Error closing existing sheet', error: e);
} }
} }
// Show new sheet
if (next != null) { if (next != null) {
try {
final relativeSafeArea = MediaQuery.of(context).relativeSafeArea(); final relativeSafeArea = MediaQuery.of(context).relativeSafeArea();
final controller = Scaffold.of(context).showBottomSheet((context) { final controller = Scaffold.of(context).showBottomSheet((context) {
logger.i(
'Building bottom sheet, relativeSafeArea: $relativeSafeArea, mounted: ${context.mounted}',
);
bool dismissOnThreshold( bool dismissOnThreshold(
DraggableScrollableNotification notification, DraggableScrollableNotification notification,
) { ) {
if (notification.extent <= 0.1) { if (notification.extent <= 0.1) {
ref.read(bottomSheetControllerProvider.notifier).requestDismiss(); logger.i('Dismissing sheet, reached min extend');
ref
.read(bottomSheetControllerProvider.notifier)
.requestDismiss();
return true; return true;
} }
return false; return false;
} }
final sheet = switch (next) { final sheet = switch (next) {
ViewTabsSheet() => ViewTabsSheet() =>
NotificationListener<DraggableScrollableNotification>( NotificationListener<DraggableScrollableNotification>(
key: ValueKey(next), key: UniqueKey(),
onNotification: dismissOnThreshold, onNotification: dismissOnThreshold,
child: _ViewTabsSheet(maxChildSize: relativeSafeArea), child: _ViewTabsSheet(maxChildSize: relativeSafeArea),
), ),
final EditUrlSheet parameter => final EditUrlSheet parameter =>
NotificationListener<DraggableScrollableNotification>( NotificationListener<DraggableScrollableNotification>(
key: ValueKey(parameter), key: UniqueKey(),
onNotification: dismissOnThreshold, onNotification: dismissOnThreshold,
child: _ViewUrlSheet( child: _ViewUrlSheet(
initialTabState: parameter.tabState, initialTabState: parameter.tabState,
@@ -301,9 +325,11 @@ class _Browser extends HookConsumerWidget {
); );
sheetController.value = controller; sheetController.value = controller;
} else { } catch (e) {
sheetController.value = null; debugPrint('Failed to show bottom sheet: $e');
} }
}
});
}); });
return DragTarget<TabDragData>( return DragTarget<TabDragData>(