From bbe8fbb2e58c570877f47c08892211adbf08a833 Mon Sep 17 00:00:00 2001 From: Fabian Freund Date: Sun, 16 Jun 2024 21:16:15 +0200 Subject: [PATCH] riverpod optimizations --- app/lib/features/bangs/presentation/widgets/site_search.dart | 2 +- .../search_browser/presentation/screens/browser.dart | 4 ++-- app/lib/features/web_view/presentation/widgets/web_view.dart | 5 +++-- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/app/lib/features/bangs/presentation/widgets/site_search.dart b/app/lib/features/bangs/presentation/widgets/site_search.dart index a9a1213e..5b277234 100644 --- a/app/lib/features/bangs/presentation/widgets/site_search.dart +++ b/app/lib/features/bangs/presentation/widgets/site_search.dart @@ -50,7 +50,7 @@ class SiteSearch extends HookConsumerWidget { .read(switchNewTabControllerProvider.notifier) .add(activeBang.getUrl(textController.text)); - ref.watch(overlayDialogProvider.notifier).dismiss(); + ref.read(overlayDialogProvider.notifier).dismiss(); } } diff --git a/app/lib/features/search_browser/presentation/screens/browser.dart b/app/lib/features/search_browser/presentation/screens/browser.dart index b786abd1..a7a8ed57 100644 --- a/app/lib/features/search_browser/presentation/screens/browser.dart +++ b/app/lib/features/search_browser/presentation/screens/browser.dart @@ -84,12 +84,12 @@ class KagiScreen extends HookConsumerWidget { final page = ref.read(webViewTabControllerProvider)?.page.value; if (page != null) { - ref.watch(overlayDialogProvider.notifier).show( + ref.read(overlayDialogProvider.notifier).show( WebPageDialog( page: page, webViewController: webViewController.value, onDismiss: - ref.watch(overlayDialogProvider.notifier).dismiss, + ref.read(overlayDialogProvider.notifier).dismiss, ), ); } diff --git a/app/lib/features/web_view/presentation/widgets/web_view.dart b/app/lib/features/web_view/presentation/widgets/web_view.dart index 5315a230..1f3e8975 100644 --- a/app/lib/features/web_view/presentation/widgets/web_view.dart +++ b/app/lib/features/web_view/presentation/widgets/web_view.dart @@ -325,8 +325,9 @@ class _WebViewState extends ConsumerState { ref.read(overlayDialogProvider.notifier).show( LoadingWebPageDialog( url!, - onDismiss: - ref.watch(overlayDialogProvider.notifier).dismiss, + onDismiss: () { + ref.read(overlayDialogProvider.notifier).dismiss(); + }, ), ); }