MrBlake/MrbWebLibre
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

check if listened before adding queries

Browse Source
This commit is contained in:
Fabian Freund
2025-09-29 11:02:14 +02:00
parent 81f04c2078
commit bb77f8c015
7 changed files with 45 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/lib/features/bangs/presentation/widgets/site_search.dart
+5 -3
View File
@@ -62,9 +62,11 @@ class SiteSearch extends HookConsumerWidget {
final searchFocusNode = useFocusNode(); final searchFocusNode = useFocusNode();
useListenableCallback(searchTextController, () { useListenableCallback(searchTextController, () {
ref if (ref.exists(searchSuggestionsProvider())) {
.read(searchSuggestionsProvider().notifier) ref
.addQuery(searchTextController.text); .read(searchSuggestionsProvider().notifier)
.addQuery(searchTextController.text);
}
}); });
final selectedBang = ref.watch(selectedBangDataProvider(domain: domain)); final selectedBang = ref.watch(selectedBangDataProvider(domain: domain));
app/lib/features/geckoview/features/browser/presentation/widgets/sheets/view_tabs.dart
+7 -5
View File
@@ -139,11 +139,13 @@ class _TabSheetHeader extends HookConsumerWidget {
); );
useListenableCallback(searchTextController, () async { useListenableCallback(searchTextController, () async {
await ref if (ref.exists(tabSearchRepositoryProvider(TabSearchPartition.preview))) {
.read( await ref
tabSearchRepositoryProvider(TabSearchPartition.preview).notifier, .read(
) tabSearchRepositoryProvider(TabSearchPartition.preview).notifier,
.addQuery(searchTextController.text); )
.addQuery(searchTextController.text);
}
}); });
return Material( return Material(
app/lib/features/geckoview/features/search/domain/providers/search_suggestions.dart
+9 -3
View File
@@ -68,9 +68,15 @@ class SearchSuggestions extends _$SearchSuggestions {
final defaultProvider = ref.watch(defaultSearchSuggestionsProvider); final defaultProvider = ref.watch(defaultSearchSuggestionsProvider);
final resolvedProvider = suggestionsProvider ?? defaultProvider; final resolvedProvider = suggestionsProvider ?? defaultProvider;
_addQueryBinding = ref _addQueryBinding = (value) {
.watch(searchSuggestionsRepositoryProvider(resolvedProvider).notifier) if (ref.exists(searchSuggestionsRepositoryProvider(resolvedProvider))) {
.addQuery; ref
.watch(
searchSuggestionsRepositoryProvider(resolvedProvider).notifier,
)
.addQuery(value);
}
};
return ref.watch(searchSuggestionsRepositoryProvider(resolvedProvider)); return ref.watch(searchSuggestionsRepositoryProvider(resolvedProvider));
} }
app/lib/features/geckoview/features/search/domain/providers/search_suggestions.g.dart
+1 -1
View File
@@ -98,7 +98,7 @@ final class SearchSuggestionsProvider
} }
} }
String _$searchSuggestionsHash() => r'8d1fb72cab374491a53f7a814f87af6a26356f42'; String _$searchSuggestionsHash() => r'e181fb417f6199648a7c6d8962b1f1d5a2cf7d27';
final class SearchSuggestionsFamily extends $Family final class SearchSuggestionsFamily extends $Family
with with
app/lib/features/geckoview/features/search/presentation/widgets/search_modules/fixed_search_suggestions.dart
+5 -3
View File
@@ -61,9 +61,11 @@ class FixedSearchTermSuggestions extends HookConsumerWidget {
final searchSuggestions = ref.watch(searchSuggestionsProvider()); final searchSuggestions = ref.watch(searchSuggestionsProvider());
useListenableCallback(searchTextController, () { useListenableCallback(searchTextController, () {
ref if (ref.exists(searchSuggestionsProvider())) {
.read(searchSuggestionsProvider().notifier) ref
.addQuery(searchTextController.text); .read(searchSuggestionsProvider().notifier)
.addQuery(searchTextController.text);
}
}); });
final prioritizedSuggestions = isSuggestableText final prioritizedSuggestions = isSuggestableText
app/lib/features/geckoview/features/search/presentation/widgets/search_modules/history_suggestions.dart
+5 -3
View File
@@ -49,9 +49,11 @@ class HistorySuggestions extends HookConsumerWidget {
final historySuggestionsAsync = ref.watch(engineHistorySuggestionsProvider); final historySuggestionsAsync = ref.watch(engineHistorySuggestionsProvider);
useListenableCallback(searchTextListenable, () async { useListenableCallback(searchTextListenable, () async {
await ref if (ref.exists(engineSuggestionsProvider)) {
.watch(engineSuggestionsProvider.notifier) await ref
.addQuery(searchTextListenable.value.text); .watch(engineSuggestionsProvider.notifier)
.addQuery(searchTextListenable.value.text);
}
}); });
if (historySuggestionsAsync.hasValue && if (historySuggestionsAsync.hasValue &&
app/lib/features/geckoview/features/search/presentation/widgets/search_modules/tab_search.dart
+13 -9
View File
@@ -68,15 +68,19 @@ class TabSearch extends HookConsumerWidget {
.value; .value;
useListenableCallback(searchTextListenable, () async { useListenableCallback(searchTextListenable, () async {
await ref if (ref.exists(tabSearchRepositoryProvider(TabSearchPartition.search))) {
.read(tabSearchRepositoryProvider(TabSearchPartition.search).notifier) await ref
.addQuery( .read(
searchTextListenable.value.text, tabSearchRepositoryProvider(TabSearchPartition.search).notifier,
// ignore: avoid_redundant_argument_values dont break things )
matchPrefix: _matchPrefix, .addQuery(
// ignore: avoid_redundant_argument_values dont break things searchTextListenable.value.text,
matchSuffix: _matchSuffix, // ignore: avoid_redundant_argument_values dont break things
); matchPrefix: _matchPrefix,
// ignore: avoid_redundant_argument_values dont break things
matchSuffix: _matchSuffix,
);
}
}); });
if (tabs.isEmpty) { if (tabs.isEmpty) {