From b0ac6c97b058c29fe8e2f9bfd244ed0ec649f8ba Mon Sep 17 00:00:00 2001
From: Fabian Freund <github@fabi.online>
Date: Sat, 6 Jun 2026 08:05:32 +0200
Subject: [PATCH] only show gesture tile with active tab

---
 .../widgets/browser_menu_sheet.dart           | 51 +++++++++----------
 1 file changed, 24 insertions(+), 27 deletions(-)

diff --git a/apps/weblibre/lib/features/geckoview/features/browser/presentation/widgets/browser_menu_sheet.dart b/apps/weblibre/lib/features/geckoview/features/browser/presentation/widgets/browser_menu_sheet.dart
index 44911e73..f0b3dab0 100644
--- a/apps/weblibre/lib/features/geckoview/features/browser/presentation/widgets/browser_menu_sheet.dart
+++ b/apps/weblibre/lib/features/geckoview/features/browser/presentation/widgets/browser_menu_sheet.dart
@@ -111,9 +111,6 @@ class _BrowserMenuSheet extends HookConsumerWidget {
     final colorScheme = Theme.of(context).colorScheme;
     final selectedTabId = ref.watch(selectedTabProvider);
     final settings = ref.watch(generalSettingsWithDefaultsProvider);
-    final gesturesEnabled = ref.watch(
-      gestureSettingsWithDefaultsProvider.select((s) => s.enabled),
-    );
 
     return DraggableScrollableSheet(
       initialChildSize: 0.85,
@@ -148,7 +145,7 @@ class _BrowserMenuSheet extends HookConsumerWidget {
                     ),
                     children: [
                       // Quick toggles (Desktop / Reader / Gestures)
-                      if (selectedTabId != null || gesturesEnabled) ...[
+                      if (selectedTabId != null) ...[
                         _QuickTogglesGrid(selectedTabId: selectedTabId),
                         const SizedBox(height: 16),
                       ],
@@ -583,9 +580,9 @@ class _PageActionsCard extends HookConsumerWidget {
 
 // ─── Quick Toggles Grid ───
 
-/// Unified bar of quick toggles. Page-scoped toggles (Desktop / Reader) appear
-/// only when a tab is selected; the global Gestures toggle appears whenever the
-/// gesture master switch is on. They are laid out as a connected, equal-width
+/// Unified bar of quick toggles (Desktop / Reader / Gestures). These appear
+/// only when a tab is selected; the Gestures toggle additionally requires the
+/// gesture master switch to be on. They are laid out as a connected, equal-width
 /// segmented bar (icon over label) that wraps to a new row past four toggles.
 class _QuickTogglesGrid extends ConsumerWidget {
   final String? selectedTabId;
@@ -652,27 +649,27 @@ class _QuickTogglesGrid extends ConsumerWidget {
           },
         ),
       );
-    }
 
-    if (gestureSettings.enabled) {
-      toggles.add(
-        _QuickToggle(
-          icon: MdiIcons.gestureSwipe,
-          label: 'Gestures',
-          active: gestureSettings.active,
-          onTap: () async {
-            await ref
-                .read(gestureSettingsRepositoryProvider.notifier)
-                .updateSettings(
-                  (s) => s.copyWith(active: !gestureSettings.active),
-                );
-          },
-          onLongPress: () {
-            Navigator.pop(context);
-            unawaited(GestureSettingsRoute().push(context));
-          },
-        ),
-      );
+      if (gestureSettings.enabled) {
+        toggles.add(
+          _QuickToggle(
+            icon: MdiIcons.gestureSwipe,
+            label: 'Gestures',
+            active: gestureSettings.active,
+            onTap: () async {
+              await ref
+                  .read(gestureSettingsRepositoryProvider.notifier)
+                  .updateSettings(
+                    (s) => s.copyWith(active: !gestureSettings.active),
+                  );
+            },
+            onLongPress: () {
+              Navigator.pop(context);
+              unawaited(GestureSettingsRoute().push(context));
+            },
+          ),
+        );
+      }
     }
 
     if (toggles.isEmpty) return const SizedBox.shrink();