fix color scheme for custom tabs

2026-06-06 11:51:36 +02:00
parent 69aad79b93
commit b0267a66b7
5 changed files with 103 additions and 8 deletions
@@ -216,12 +216,11 @@ class EngineSettingsReplicationService
                settings.globalPrivacyControlEnabled,
              );
            }
-            if (previous.value?.preferredColorScheme !=
-                settings.preferredColorScheme) {
-              await _service.preferredColorScheme(
-                settings.preferredColorScheme,
-              );
-            }
+            // Note: preferredColorScheme is intentionally NOT replicated from the
+            // engine settings here. The app theme (generalSettings.themeMode) is the
+            // sole source of truth for the color scheme; see the themeMode listener
+            // above. EngineSettings.preferredColorScheme is vestigial and always
+            // `system`, so replicating it would clobber the real theme (issue #436).
            if (previous.value?.cookieBannerHandlingMode !=
                settings.cookieBannerHandlingMode) {
              await _service.cookieBannerHandlingMode(