cache tab deletets for faster ui rebuild

This commit is contained in:
Fabian Freund
2025-10-13 12:33:16 +02:00
parent 8cf3794525
commit a536fe30da
6 changed files with 101 additions and 3 deletions
@@ -0,0 +1,23 @@
import 'dart:async';
import 'package:riverpod_annotation/riverpod_annotation.dart';
part 'tab_delete_cache.g.dart';
@Riverpod(keepAlive: true)
class TabDeleteCache extends _$TabDeleteCache {
void delete(String tabId) {
state = {...state, tabId};
Timer(const Duration(seconds: 3), () {
if (ref.mounted) {
state = {...state}..remove(tabId);
}
});
}
@override
Set<String> build() {
return {};
}
}
@@ -0,0 +1,63 @@
// GENERATED CODE - DO NOT MODIFY BY HAND
part of 'tab_delete_cache.dart';
// **************************************************************************
// RiverpodGenerator
// **************************************************************************
// GENERATED CODE - DO NOT MODIFY BY HAND
// ignore_for_file: type=lint, type=warning
@ProviderFor(TabDeleteCache)
const tabDeleteCacheProvider = TabDeleteCacheProvider._();
final class TabDeleteCacheProvider
extends $NotifierProvider<TabDeleteCache, Set<String>> {
const TabDeleteCacheProvider._()
: super(
from: null,
argument: null,
retry: null,
name: r'tabDeleteCacheProvider',
isAutoDispose: false,
dependencies: null,
$allTransitiveDependencies: null,
);
@override
String debugGetCreateSourceHash() => _$tabDeleteCacheHash();
@$internal
@override
TabDeleteCache create() => TabDeleteCache();
/// {@macro riverpod.override_with_value}
Override overrideWithValue(Set<String> value) {
return $ProviderOverride(
origin: this,
providerOverride: $SyncValueProvider<Set<String>>(value),
);
}
}
String _$tabDeleteCacheHash() => r'd645d41fc2bf7b132f0cbdf1914289ca66783689';
abstract class _$TabDeleteCache extends $Notifier<Set<String>> {
Set<String> build();
@$mustCallSuper
@override
void runBuild() {
final created = build();
final ref = this.ref as $Ref<Set<String>, Set<String>>;
final element =
ref.element
as $ClassProviderElement<
AnyNotifier<Set<String>, Set<String>>,
Set<String>,
Object?,
Object?
>;
element.handleValue(ref, created);
}
}
@@ -17,11 +17,13 @@
* You should have received a copy of the GNU Affero General Public License * You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>. * along with this program. If not, see <http://www.gnu.org/licenses/>.
*/ */
import 'package:collection/collection.dart';
import 'package:fast_equatable/fast_equatable.dart'; import 'package:fast_equatable/fast_equatable.dart';
import 'package:flutter_mozilla_components/flutter_mozilla_components.dart'; import 'package:flutter_mozilla_components/flutter_mozilla_components.dart';
import 'package:riverpod_annotation/riverpod_annotation.dart'; import 'package:riverpod_annotation/riverpod_annotation.dart';
import 'package:weblibre/core/logger.dart'; import 'package:weblibre/core/logger.dart';
import 'package:weblibre/features/geckoview/domain/providers.dart'; import 'package:weblibre/features/geckoview/domain/providers.dart';
import 'package:weblibre/features/geckoview/domain/providers/tab_delete_cache.dart';
part 'tab_list.g.dart'; part 'tab_list.g.dart';
@@ -49,7 +51,10 @@ class TabList extends _$TabList {
); );
final tabListSub = eventService.tabListEvents.listen((tabs) { final tabListSub = eventService.tabListEvents.listen((tabs) {
final equatableTabs = EquatableValue(tabs); final deletedTabs = ref.read(tabDeleteCacheProvider);
final equatableTabs = EquatableValue(
tabs.whereNot(deletedTabs.contains).toList(),
);
if (equatableTabs != state) { if (equatableTabs != state) {
state = equatableTabs; state = equatableTabs;
@@ -41,7 +41,7 @@ final class TabListProvider
} }
} }
String _$tabListHash() => r'0b9ca1e089a59895df4cbf28691c2849a7004f08'; String _$tabListHash() => r'e93d68e7c362454e803711e5c38abcc8f188b427';
abstract class _$TabList extends $Notifier<EquatableValue<List<String>>> { abstract class _$TabList extends $Notifier<EquatableValue<List<String>>> {
EquatableValue<List<String>> build(); EquatableValue<List<String>> build();
@@ -28,6 +28,7 @@ import 'package:weblibre/core/logger.dart';
import 'package:weblibre/features/geckoview/domain/entities/states/tab.dart'; import 'package:weblibre/features/geckoview/domain/entities/states/tab.dart';
import 'package:weblibre/features/geckoview/domain/providers.dart'; import 'package:weblibre/features/geckoview/domain/providers.dart';
import 'package:weblibre/features/geckoview/domain/providers/selected_tab.dart'; import 'package:weblibre/features/geckoview/domain/providers/selected_tab.dart';
import 'package:weblibre/features/geckoview/domain/providers/tab_delete_cache.dart';
import 'package:weblibre/features/geckoview/domain/providers/tab_list.dart'; import 'package:weblibre/features/geckoview/domain/providers/tab_list.dart';
import 'package:weblibre/features/geckoview/domain/providers/tab_state.dart'; import 'package:weblibre/features/geckoview/domain/providers/tab_state.dart';
import 'package:weblibre/features/geckoview/features/tabs/data/models/container_data.dart'; import 'package:weblibre/features/geckoview/features/tabs/data/models/container_data.dart';
@@ -345,6 +346,8 @@ class TabRepository extends _$TabRepository {
await _selectNextTab(tabId); await _selectNextTab(tabId);
} }
ref.read(tabDeleteCacheProvider.notifier).delete(tabId);
return _tabsService.removeTab(tabId: tabId); return _tabsService.removeTab(tabId: tabId);
} }
@@ -354,6 +357,10 @@ class TabRepository extends _$TabRepository {
await _selectNextTab(selectedTab!); await _selectNextTab(selectedTab!);
} }
for (final tabId in tabIds) {
ref.read(tabDeleteCacheProvider.notifier).delete(tabId);
}
return _tabsService.removeTabs(ids: tabIds); return _tabsService.removeTabs(ids: tabIds);
} }
@@ -41,7 +41,7 @@ final class TabRepositoryProvider
} }
} }
String _$tabRepositoryHash() => r'6fd5f78d5e5b728984b10a8824e06e82c5c26f4c'; String _$tabRepositoryHash() => r'c3dd50e6263df20ce803e979151997e0b10e0c01';
abstract class _$TabRepository extends $Notifier<void> { abstract class _$TabRepository extends $Notifier<void> {
void build(); void build();