MrBlake/MrbWebLibre
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

optimize rebuilds by sampling input

Browse Source
This commit is contained in:
Fabian Freund
2025-04-24 23:26:55 +02:00
parent c45f44632c
commit 9a57acfccd
7 changed files with 163 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/lib/features/geckoview/features/search/presentation/screens/search.dart
+8 -3
View File
@@ -13,6 +13,7 @@ import 'package:lensai/features/geckoview/features/search/presentation/widgets/s
import 'package:lensai/features/geckoview/features/search/presentation/widgets/search_modules/history_suggestions.dart';
import 'package:lensai/features/geckoview/features/search/presentation/widgets/search_modules/search_suggestions.dart';
import 'package:lensai/features/geckoview/features/search/presentation/widgets/search_modules/tab_search.dart';
import 'package:lensai/presentation/hooks/sampled_value_notifier.dart';
import 'package:lensai/utils/uri_parser.dart' as uri_parser;
class SearchScreen extends HookConsumerWidget {
@@ -27,6 +28,10 @@ class SearchScreen extends HookConsumerWidget {
final searchTextController = useTextEditingController(
text: initialSearchText,
);
final sampledSearchText = useSampledValueNotifier(
source: searchTextController,
sampleDuration: const Duration(milliseconds: 150),
);
final searchFocusNode = useFocusNode();
final defaultSearchBang = ref.watch(
@@ -116,9 +121,9 @@ class SearchScreen extends HookConsumerWidget {
submitSearch: submitSearch,
),
const SliverToBoxAdapter(child: Divider()),
TabSearch(searchTextController: searchTextController),
FeedSearch(searchTextController: searchTextController),
HistorySuggestions(searchTextController: searchTextController),
TabSearch(searchTextListenable: sampledSearchText),
FeedSearch(searchTextNotifier: sampledSearchText),
HistorySuggestions(searchTextListenable: sampledSearchText),
],
),
),
app/lib/features/geckoview/features/search/presentation/widgets/search_modules/feed_search.dart
+5 -4
View File
@@ -1,3 +1,4 @@
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter_markdown/flutter_markdown.dart';
import 'package:hooks_riverpod/hooks_riverpod.dart';
@@ -20,9 +21,9 @@ class FeedSearch extends HookConsumerWidget {
static const _matchPrefix = '***';
static const _matchSuffix = '***';
final TextEditingController searchTextController;
final ValueListenable<TextEditingValue> searchTextNotifier;
const FeedSearch({required this.searchTextController});
const FeedSearch({required this.searchTextNotifier});
@override
Widget build(BuildContext context, WidgetRef ref) {
@@ -30,11 +31,11 @@ class FeedSearch extends HookConsumerWidget {
final articlesAsync = ref.watch(articleSearchProvider(null));
useListenableCallback(searchTextController, () async {
useListenableCallback(searchTextNotifier, () async {
await ref
.read(articleSearchProvider(null).notifier)
.search(
searchTextController.text,
searchTextNotifier.value.text,
// ignore: avoid_redundant_argument_values dont break things
matchPrefix: _matchPrefix,
// ignore: avoid_redundant_argument_values dont break things
app/lib/features/geckoview/features/search/presentation/widgets/search_modules/history_suggestions.dart
+5 -4
View File
@@ -1,3 +1,4 @@
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter_hooks/flutter_hooks.dart';
import 'package:go_router/go_router.dart';
@@ -14,18 +15,18 @@ import 'package:skeletonizer/skeletonizer.dart';
import 'package:sliver_tools/sliver_tools.dart';
class HistorySuggestions extends HookConsumerWidget {
final TextEditingController searchTextController;
final ValueListenable<TextEditingValue> searchTextListenable;
const HistorySuggestions({super.key, required this.searchTextController});
const HistorySuggestions({super.key, required this.searchTextListenable});
@override
Widget build(BuildContext context, WidgetRef ref) {
final historySuggestionsAsync = ref.watch(engineHistorySuggestionsProvider);
useListenableCallback(searchTextController, () async {
useListenableCallback(searchTextListenable, () async {
await ref
.watch(engineSuggestionsProvider.notifier)
.addQuery(searchTextController.text);
.addQuery(searchTextListenable.value.text);
});
if (historySuggestionsAsync.hasValue &&
app/lib/features/geckoview/features/search/presentation/widgets/search_modules/tab_search.dart
+6 -5
View File
@@ -1,3 +1,4 @@
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter_hooks/flutter_hooks.dart';
import 'package:flutter_markdown/flutter_markdown.dart';
@@ -20,9 +21,9 @@ class TabSearch extends HookConsumerWidget {
static const _matchPrefix = '***';
static const _matchSuffix = '***';
final TextEditingController searchTextController;
final ValueListenable<TextEditingValue> searchTextListenable;
const TabSearch({required this.searchTextController});
const TabSearch({required this.searchTextListenable});
@override
Widget build(BuildContext context, WidgetRef ref) {
@@ -46,11 +47,11 @@ class TabSearch extends HookConsumerWidget {
)
.value;
useListenableCallback(searchTextController, () async {
useListenableCallback(searchTextListenable, () async {
await ref
.read(tabSearchRepositoryProvider(TabSearchPartition.search).notifier)
.addQuery(
searchTextController.text,
searchTextListenable.value.text,
// ignore: avoid_redundant_argument_values dont break things
matchPrefix: _matchPrefix,
// ignore: avoid_redundant_argument_values dont break things
@@ -81,7 +82,7 @@ class TabSearch extends HookConsumerWidget {
selectedContainer.value = null;
},
containerFilter: (container) => (container.tabCount ?? 0) > 0,
searchTextController: searchTextController,
searchTextListenable: searchTextListenable,
),
],
),
app/lib/features/geckoview/features/tabs/presentation/widgets/container_chips.dart
+5 -4
View File
@@ -1,3 +1,4 @@
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter_hooks/flutter_hooks.dart';
import 'package:hooks_riverpod/hooks_riverpod.dart';
@@ -20,22 +21,22 @@ class ContainerChips extends HookConsumerWidget {
final void Function(ContainerDataWithCount)? onSelected;
final void Function(ContainerDataWithCount)? onDeleted;
final TextEditingController? searchTextController;
final ValueListenable<TextEditingValue>? searchTextListenable;
const ContainerChips({
required this.selectedContainer,
required this.onSelected,
required this.onDeleted,
this.containerFilter,
this.searchTextController,
this.searchTextListenable,
this.displayMenu = true,
});
@override
Widget build(BuildContext context, WidgetRef ref) {
final searchText = useListenableSelector(
searchTextController,
() => searchTextController?.text,
searchTextListenable,
() => searchTextListenable?.value.text,
);
final containersAsync = ref.watch(