added theme setting; fixed light theme issues

This commit is contained in:
Fabian Freund
2024-06-20 14:15:16 +02:00
parent db84e43e0a
commit 98e9705f1e
9 changed files with 114 additions and 18 deletions
@@ -23,7 +23,10 @@ class TabsActionButton extends HookConsumerWidget {
), ),
child: Container( child: Container(
decoration: BoxDecoration( decoration: BoxDecoration(
border: Border.all(width: 2.0, color: Colors.white), border: Border.all(
width: 2.0,
color: DefaultTextStyle.of(context).style.color!,
),
borderRadius: BorderRadius.circular(5.0), borderRadius: BorderRadius.circular(5.0),
), ),
constraints: const BoxConstraints(minWidth: 25.0), constraints: const BoxConstraints(minWidth: 25.0),
@@ -31,7 +34,6 @@ class TabsActionButton extends HookConsumerWidget {
child: Text( child: Text(
tabCount.toString(), tabCount.toString(),
style: const TextStyle( style: const TextStyle(
color: Colors.white,
fontWeight: FontWeight.bold, fontWeight: FontWeight.bold,
fontSize: 14.0, fontSize: 14.0,
), ),
@@ -1,6 +1,7 @@
import 'package:bang_navigator/features/content_block/data/models/host.dart'; import 'package:bang_navigator/features/content_block/data/models/host.dart';
import 'package:copy_with_extension/copy_with_extension.dart'; import 'package:copy_with_extension/copy_with_extension.dart';
import 'package:fast_equatable/fast_equatable.dart'; import 'package:fast_equatable/fast_equatable.dart';
import 'package:flutter/material.dart';
part 'settings.g.dart'; part 'settings.g.dart';
@@ -13,6 +14,7 @@ class Settings with FastEquatable {
final bool launchUrlExternal; final bool launchUrlExternal;
final bool enableContentBlocking; final bool enableContentBlocking;
final Set<HostSource> enableHostList; final Set<HostSource> enableHostList;
final ThemeMode themeMode;
Settings({ Settings({
required this.kagiSession, required this.kagiSession,
@@ -22,6 +24,7 @@ class Settings with FastEquatable {
required this.launchUrlExternal, required this.launchUrlExternal,
required this.enableContentBlocking, required this.enableContentBlocking,
required this.enableHostList, required this.enableHostList,
required this.themeMode,
}); });
Settings.withDefaults({ Settings.withDefaults({
@@ -32,12 +35,14 @@ class Settings with FastEquatable {
bool? launchUrlExternal, bool? launchUrlExternal,
bool? enableContentBlocking, bool? enableContentBlocking,
Set<HostSource>? enableHostList, Set<HostSource>? enableHostList,
ThemeMode? themeMode,
}) : showEarlyAccessFeatures = showEarlyAccessFeatures ?? true, }) : showEarlyAccessFeatures = showEarlyAccessFeatures ?? true,
incognitoMode = incognitoMode ?? true, incognitoMode = incognitoMode ?? true,
enableJavascript = enableJavascript ?? true, enableJavascript = enableJavascript ?? true,
launchUrlExternal = launchUrlExternal ?? false, launchUrlExternal = launchUrlExternal ?? false,
enableContentBlocking = enableContentBlocking ?? true, enableContentBlocking = enableContentBlocking ?? true,
enableHostList = enableHostList ?? {HostSource.stevenBlackUnified}; enableHostList = enableHostList ?? {HostSource.stevenBlackUnified},
themeMode = themeMode ?? ThemeMode.dark;
@override @override
bool get cacheHash => true; bool get cacheHash => true;
@@ -51,5 +56,6 @@ class Settings with FastEquatable {
launchUrlExternal, launchUrlExternal,
enableContentBlocking, enableContentBlocking,
enableHostList, enableHostList,
themeMode,
]; ];
} }
@@ -21,6 +21,8 @@ abstract class _$SettingsCWProxy {
Settings enableHostList(Set<HostSource> enableHostList); Settings enableHostList(Set<HostSource> enableHostList);
Settings themeMode(ThemeMode themeMode);
/// This function **does support** nullification of nullable fields. All `null` values passed to `non-nullable` fields will be ignored. You can also use `Settings(...).copyWith.fieldName(...)` to override fields one at a time with nullification support. /// This function **does support** nullification of nullable fields. All `null` values passed to `non-nullable` fields will be ignored. You can also use `Settings(...).copyWith.fieldName(...)` to override fields one at a time with nullification support.
/// ///
/// Usage /// Usage
@@ -35,6 +37,7 @@ abstract class _$SettingsCWProxy {
bool? launchUrlExternal, bool? launchUrlExternal,
bool? enableContentBlocking, bool? enableContentBlocking,
Set<HostSource>? enableHostList, Set<HostSource>? enableHostList,
ThemeMode? themeMode,
}); });
} }
@@ -71,6 +74,9 @@ class _$SettingsCWProxyImpl implements _$SettingsCWProxy {
Settings enableHostList(Set<HostSource> enableHostList) => Settings enableHostList(Set<HostSource> enableHostList) =>
this(enableHostList: enableHostList); this(enableHostList: enableHostList);
@override
Settings themeMode(ThemeMode themeMode) => this(themeMode: themeMode);
@override @override
/// This function **does support** nullification of nullable fields. All `null` values passed to `non-nullable` fields will be ignored. You can also use `Settings(...).copyWith.fieldName(...)` to override fields one at a time with nullification support. /// This function **does support** nullification of nullable fields. All `null` values passed to `non-nullable` fields will be ignored. You can also use `Settings(...).copyWith.fieldName(...)` to override fields one at a time with nullification support.
@@ -87,6 +93,7 @@ class _$SettingsCWProxyImpl implements _$SettingsCWProxy {
Object? launchUrlExternal = const $CopyWithPlaceholder(), Object? launchUrlExternal = const $CopyWithPlaceholder(),
Object? enableContentBlocking = const $CopyWithPlaceholder(), Object? enableContentBlocking = const $CopyWithPlaceholder(),
Object? enableHostList = const $CopyWithPlaceholder(), Object? enableHostList = const $CopyWithPlaceholder(),
Object? themeMode = const $CopyWithPlaceholder(),
}) { }) {
return Settings( return Settings(
kagiSession: kagiSession == const $CopyWithPlaceholder() kagiSession: kagiSession == const $CopyWithPlaceholder()
@@ -125,6 +132,10 @@ class _$SettingsCWProxyImpl implements _$SettingsCWProxy {
? _value.enableHostList ? _value.enableHostList
// ignore: cast_nullable_to_non_nullable // ignore: cast_nullable_to_non_nullable
: enableHostList as Set<HostSource>, : enableHostList as Set<HostSource>,
themeMode: themeMode == const $CopyWithPlaceholder() || themeMode == null
? _value.themeMode
// ignore: cast_nullable_to_non_nullable
: themeMode as ThemeMode,
); );
} }
} }
@@ -1,6 +1,7 @@
import 'package:bang_navigator/features/content_block/data/models/host.dart'; import 'package:bang_navigator/features/content_block/data/models/host.dart';
import 'package:bang_navigator/features/settings/data/models/settings.dart'; import 'package:bang_navigator/features/settings/data/models/settings.dart';
import 'package:collection/collection.dart'; import 'package:collection/collection.dart';
import 'package:flutter/material.dart';
import 'package:flutter_secure_storage/flutter_secure_storage.dart'; import 'package:flutter_secure_storage/flutter_secure_storage.dart';
import 'package:riverpod_annotation/riverpod_annotation.dart'; import 'package:riverpod_annotation/riverpod_annotation.dart';
import 'package:shared_preferences/shared_preferences.dart'; import 'package:shared_preferences/shared_preferences.dart';
@@ -9,6 +10,22 @@ part 'settings_repository.g.dart';
typedef UpdateSettingsFunc = Settings Function(Settings currentSettings); typedef UpdateSettingsFunc = Settings Function(Settings currentSettings);
Set<HostSource>? _parseHostSources(List<String>? input) => input
?.map(
(list) =>
HostSource.values.firstWhereOrNull((source) => source.name == list),
)
.whereNotNull()
.toSet();
ThemeMode? _parseThemeMode(int? index) {
if (index != null && index < ThemeMode.values.length) {
return ThemeMode.values[index];
}
return null;
}
@Riverpod(keepAlive: true) @Riverpod(keepAlive: true)
class SettingsRepository extends _$SettingsRepository { class SettingsRepository extends _$SettingsRepository {
static const _sessionStorageKey = 'b4ng_kagi_session'; static const _sessionStorageKey = 'b4ng_kagi_session';
@@ -18,6 +35,7 @@ class SettingsRepository extends _$SettingsRepository {
static const _launchExternalStorageKey = 'b4ng_settings_launch_external'; static const _launchExternalStorageKey = 'b4ng_settings_launch_external';
static const _contentBlockingStorageKey = 'b4ng_settings_content_blocking'; static const _contentBlockingStorageKey = 'b4ng_settings_content_blocking';
static const _enableHostListStorageKey = 'b4ng_settings_host_lists'; static const _enableHostListStorageKey = 'b4ng_settings_host_lists';
static const _themeModeStorageKey = 'b4ng_settings_theme_mode';
final FlutterSecureStorage _flutterSecureStorage; final FlutterSecureStorage _flutterSecureStorage;
final Future<SharedPreferences> _sharedPreferences; final Future<SharedPreferences> _sharedPreferences;
@@ -88,6 +106,13 @@ class SettingsRepository extends _$SettingsRepository {
); );
} }
if (newSettings.themeMode != oldSettings.themeMode) {
await sharedPreferences.setInt(
_themeModeStorageKey,
newSettings.themeMode.index,
);
}
ref.invalidateSelf(); ref.invalidateSelf();
} }
} }
@@ -105,14 +130,11 @@ class SettingsRepository extends _$SettingsRepository {
launchUrlExternal: sharedPreferences.getBool(_launchExternalStorageKey), launchUrlExternal: sharedPreferences.getBool(_launchExternalStorageKey),
enableContentBlocking: enableContentBlocking:
sharedPreferences.getBool(_contentBlockingStorageKey), sharedPreferences.getBool(_contentBlockingStorageKey),
enableHostList: sharedPreferences enableHostList: _parseHostSources(
.getStringList(_enableHostListStorageKey) sharedPreferences.getStringList(_enableHostListStorageKey),
?.map( ),
(list) => HostSource.values themeMode:
.firstWhereOrNull((source) => source.name == list), _parseThemeMode(sharedPreferences.getInt(_themeModeStorageKey)),
)
.whereNotNull()
.toSet(),
); );
} }
} }
@@ -7,7 +7,7 @@ part of 'settings_repository.dart';
// ************************************************************************** // **************************************************************************
String _$settingsRepositoryHash() => String _$settingsRepositoryHash() =>
r'9d0e8b8452f85ca33b8f13a4bbcb69212e7d29bd'; r'2fed76bdc3132729f1018f8e4c9d493ee11831a0';
/// See also [SettingsRepository]. /// See also [SettingsRepository].
@ProviderFor(SettingsRepository) @ProviderFor(SettingsRepository)
@@ -46,8 +46,7 @@ class SettingsScreen extends HookConsumerWidget {
final settings = ref.watch( final settings = ref.watch(
settingsRepositoryProvider.select( settingsRepositoryProvider.select(
(value) => (value) => value.valueOrNull ?? Settings.withDefaults(),
value.valueOrNull ?? Settings.withDefaults(kagiSession: null),
), ),
); );
@@ -146,6 +145,49 @@ class SettingsScreen extends HookConsumerWidget {
height: 16, height: 16,
), ),
_buildSection(theme, 'General'), _buildSection(theme, 'General'),
Padding(
padding: const EdgeInsets.symmetric(horizontal: 16.0, vertical: 8),
child: Column(
mainAxisSize: MainAxisSize.min,
crossAxisAlignment: CrossAxisAlignment.start,
children: [
Text(
'Theme',
style: theme.textTheme.bodyLarge,
),
Center(
child: SegmentedButton<ThemeMode>(
segments: const [
ButtonSegment(
value: ThemeMode.system,
icon: Icon(Icons.brightness_auto),
label: Text('System'),
),
ButtonSegment(
value: ThemeMode.light,
icon: Icon(Icons.light_mode),
label: Text('Light'),
),
ButtonSegment(
value: ThemeMode.dark,
icon: Icon(Icons.dark_mode),
label: Text('Dark'),
),
],
selected: {settings.themeMode},
onSelectionChanged: (value) async {
await ref
.read(saveSettingsControllerProvider.notifier)
.save(
(currentSettings) =>
currentSettings.copyWith.themeMode(value.first),
);
},
),
),
],
),
),
SwitchListTile.adaptive( SwitchListTile.adaptive(
title: const Text('Incognito Mode'), title: const Text('Incognito Mode'),
subtitle: const Text( subtitle: const Text(
@@ -269,7 +311,9 @@ class SettingsScreen extends HookConsumerWidget {
content: Padding( content: Padding(
padding: const EdgeInsets.only(top: 8.0), padding: const EdgeInsets.only(top: 8.0),
child: DefaultTextStyle( child: DefaultTextStyle(
style: GoogleFonts.robotoMono(), style: GoogleFonts.robotoMono(
textStyle: DefaultTextStyle.of(context).style,
),
child: Table( child: Table(
columnWidths: const {0: FixedColumnWidth(100)}, columnWidths: const {0: FixedColumnWidth(100)},
children: [ children: [
@@ -11,7 +11,9 @@ class SyncDetailsTable extends StatelessWidget {
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {
return DefaultTextStyle( return DefaultTextStyle(
style: GoogleFonts.robotoMono(), style: GoogleFonts.robotoMono(
textStyle: DefaultTextStyle.of(context).style,
),
child: Table( child: Table(
columnWidths: const {0: FixedColumnWidth(100)}, columnWidths: const {0: FixedColumnWidth(100)},
children: [ children: [
@@ -6,7 +6,7 @@ part of 'providers.dart';
// RiverpodGenerator // RiverpodGenerator
// ************************************************************************** // **************************************************************************
String _$blockContentHostsHash() => r'5a6b90a2884342ddb068f2b66d18ed83e42e5108'; String _$blockContentHostsHash() => r'41855093d8376152244ae37f98e66eea7c74aa32';
/// See also [blockContentHosts]. /// See also [blockContentHosts].
@ProviderFor(blockContentHosts) @ProviderFor(blockContentHosts)
+10 -1
View File
@@ -1,5 +1,7 @@
import 'package:bang_navigator/core/error_observer.dart'; import 'package:bang_navigator/core/error_observer.dart';
import 'package:bang_navigator/domain/services/app_initialization.dart'; import 'package:bang_navigator/domain/services/app_initialization.dart';
import 'package:bang_navigator/features/settings/data/models/settings.dart';
import 'package:bang_navigator/features/settings/data/repositories/settings_repository.dart';
import 'package:bang_navigator/presentation/hooks/on_initialization.dart'; import 'package:bang_navigator/presentation/hooks/on_initialization.dart';
import 'package:bang_navigator/presentation/widgets/main_app.dart'; import 'package:bang_navigator/presentation/widgets/main_app.dart';
import 'package:dynamic_color/dynamic_color.dart'; import 'package:dynamic_color/dynamic_color.dart';
@@ -21,6 +23,13 @@ void main() async {
observers: const [ErrorObserver()], observers: const [ErrorObserver()],
child: HookConsumer( child: HookConsumer(
builder: (context, ref, child) { builder: (context, ref, child) {
final themeMode = ref.watch(
settingsRepositoryProvider.select(
(value) =>
(value.valueOrNull ?? Settings.withDefaults()).themeMode,
),
);
useOnInitialization( useOnInitialization(
() async { () async {
await ref await ref
@@ -40,7 +49,7 @@ void main() async {
useMaterial3: true, useMaterial3: true,
colorScheme: darkDynamic?.harmonized(), colorScheme: darkDynamic?.harmonized(),
), ),
themeMode: ThemeMode.dark, themeMode: themeMode,
); );
}, },
); );