MrBlake/MrbWebLibre
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

guard uninitialized state

Browse Source
This commit is contained in:
Fabian Freund
2025-06-23 22:32:19 +02:00
parent 12c9d32a9b
commit 967ff8fd6d
4 changed files with 14 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/lib/features/geckoview/features/find_in_page/presentation/controllers/find_in_page.dart
+11 -8
View File
@@ -50,15 +50,18 @@ class FindInPageController extends _$FindInPageController {
fireImmediately: true, fireImmediately: true,
selectedTabStateProvider, selectedTabStateProvider,
(previous, next) async { (previous, next) async {
if (state.visible && state.lastSearchText.isNotEmpty) { //Ensure state is already initialized
if (previous != null && next != null) { if (stateOrNull != null) {
final loadingOrReloading = if (state.visible && state.lastSearchText.isNotEmpty) {
previous.isLoading == true && next.isLoading == false; if (previous != null && next != null) {
final tabSwitchWithoutResults = final loadingOrReloading =
previous.id != next.id && !next.findResultState.hasMatches; previous.isLoading == true && next.isLoading == false;
final tabSwitchWithoutResults =
previous.id != next.id && !next.findResultState.hasMatches;
if (loadingOrReloading || tabSwitchWithoutResults) { if (loadingOrReloading || tabSwitchWithoutResults) {
await findAll(text: state.lastSearchText!); await findAll(text: state.lastSearchText!);
}
} }
} }
} }
app/lib/features/geckoview/features/find_in_page/presentation/controllers/find_in_page.g.dart
+1 -1
View File
@@ -7,7 +7,7 @@ part of 'find_in_page.dart';
// ************************************************************************** // **************************************************************************
String _$findInPageControllerHash() => String _$findInPageControllerHash() =>
r'63a2fbf4f75be59d341501c58512792de82fdb3d'; r'ab421be931406325bf6b22dd9f545117ea426665';
/// See also [FindInPageController]. /// See also [FindInPageController].
@ProviderFor(FindInPageController) @ProviderFor(FindInPageController)
app/lib/features/geckoview/features/tabs/domain/providers/selected_container.dart
+1 -1
View File
@@ -80,7 +80,7 @@ class SelectedContainer extends _$SelectedContainer {
fireImmediately: true, fireImmediately: true,
containersWithCountProvider, containersWithCountProvider,
(previous, next) { (previous, next) {
if (state != null && next.valueOrNull != null) { if (stateOrNull != null && next.valueOrNull != null) {
if (!next.value!.any((container) => container.id == state)) { if (!next.value!.any((container) => container.id == state)) {
clearContainer(); clearContainer();
} }
app/lib/features/geckoview/features/tabs/domain/providers/selected_container.g.dart
+1 -1
View File
@@ -25,7 +25,7 @@ final selectedContainerDataProvider =
@Deprecated('Will be removed in 3.0. Use Ref instead') @Deprecated('Will be removed in 3.0. Use Ref instead')
// ignore: unused_element // ignore: unused_element
typedef SelectedContainerDataRef = AutoDisposeStreamProviderRef<ContainerData?>; typedef SelectedContainerDataRef = AutoDisposeStreamProviderRef<ContainerData?>;
String _$selectedContainerHash() => r'075190a8a58cc6de8ce554b0a6ed54809832fdb0'; String _$selectedContainerHash() => r'736a60b8f19273d3bdc25d1717e3a613384e59a6';
/// See also [SelectedContainer]. /// See also [SelectedContainer].
@ProviderFor(SelectedContainer) @ProviderFor(SelectedContainer)