switch from timestamps to event sequence for events

packages/flutter_mozilla_components/lib/src/domain/services/gecko_addon.dart

@@ -51,18 +51,18 @@ class GeckoAddonService extends GeckoAddonEvents {
 
   @override
   void onRemoveWebExtensionAction(
-    int timestamp,
+    int sequence,
     String extensionId,
     WebExtensionActionType actionType,
   ) {
     switch (actionType) {
       case WebExtensionActionType.browser:
-        _browserExtensionSubject.addWhenMoreRecent(timestamp, extensionId, (
+        _browserExtensionSubject.addWhenMoreRecent(sequence, extensionId, (
           extensionId: extensionId,
           data: null,
         ));
       case WebExtensionActionType.page:
-        _pageExtensionSubject.addWhenMoreRecent(timestamp, extensionId, (
+        _pageExtensionSubject.addWhenMoreRecent(sequence, extensionId, (
           extensionId: extensionId,
           data: null,
         ));
@@ -71,19 +71,19 @@ class GeckoAddonService extends GeckoAddonEvents {
 
   @override
   void onUpdateWebExtensionIcon(
-    int timestamp,
+    int sequence,
     String extensionId,
     WebExtensionActionType actionType,
     Uint8List icon,
   ) {
     switch (actionType) {
       case WebExtensionActionType.browser:
-        _browserIconSubject.addWhenMoreRecent(timestamp, extensionId, (
+        _browserIconSubject.addWhenMoreRecent(sequence, extensionId, (
           extensionId: extensionId,
           bytes: icon,
         ));
       case WebExtensionActionType.page:
-        _pageIconSubject.addWhenMoreRecent(timestamp, extensionId, (
+        _pageIconSubject.addWhenMoreRecent(sequence, extensionId, (
           extensionId: extensionId,
           bytes: icon,
         ));
@@ -92,19 +92,19 @@ class GeckoAddonService extends GeckoAddonEvents {
 
   @override
   void onUpsertWebExtensionAction(
-    int timestamp,
+    int sequence,
     String extensionId,
     WebExtensionActionType actionType,
     WebExtensionData extensionData,
   ) {
     switch (actionType) {
       case WebExtensionActionType.browser:
-        _browserExtensionSubject.addWhenMoreRecent(timestamp, extensionId, (
+        _browserExtensionSubject.addWhenMoreRecent(sequence, extensionId, (
           extensionId: extensionId,
           data: extensionData,
         ));
       case WebExtensionActionType.page:
-        _pageExtensionSubject.addWhenMoreRecent(timestamp, extensionId, (
+        _pageExtensionSubject.addWhenMoreRecent(sequence, extensionId, (
           extensionId: extensionId,
           data: extensionData,
         ));

packages/flutter_mozilla_components/lib/src/domain/services/gecko_browser_extension.dart

@@ -58,8 +58,8 @@ class GeckoBrowserExtensionService extends BrowserExtensionEvents {
   }
 
   @override
-  void onFeedRequested(int timestamp, String url) {
-    _feedRequest.addWhenMoreRecent(timestamp, null, url);
+  void onFeedRequested(int sequence, String url) {
+    _feedRequest.addWhenMoreRecent(sequence, null, url);
   }
 
   void dispose() {

packages/flutter_mozilla_components/lib/src/domain/services/gecko_event.dart

@@ -20,6 +20,7 @@ typedef ThumbnailEvent = ({String tabId, Uint8List? bytes});
 typedef FindResultsEvent = ({String tabId, List<FindResultState> results});
 typedef LongPressEvent = ({String tabId, HitResult hitResult});
 typedef ScrollEvent = ({String tabId, int scrollY});
+typedef ManifestUpdateEvent = ({String tabId, PwaManifest? manifest});
 
 class GeckoEventService extends GeckoStateEvents {
   // Stream controllers
@@ -44,6 +45,7 @@ class GeckoEventService extends GeckoStateEvents {
 
   final _tabAddedSubject = PublishSubject<String>();
   final _mlProgressSubject = PublishSubject<MlProgressData>();
+  final _manifestUpdateSubject = PublishSubject<ManifestUpdateEvent>();
 
   // Event streams
   ValueStream<bool> get viewReadyStateEvents => _viewStateSubject.stream;
@@ -68,52 +70,46 @@ class GeckoEventService extends GeckoStateEvents {
 
   Stream<String> get tabAddedStream => _tabAddedSubject.stream;
   Stream<MlProgressData> get mlProgressEvents => _mlProgressSubject.stream;
+  Stream<ManifestUpdateEvent> get manifestUpdateEvents =>
+      _manifestUpdateSubject.stream;
 
   @override
-  void onViewReadyStateChange(int timestamp, bool state) {
-    _viewStateSubject.addWhenMoreRecent(timestamp, null, state);
+  void onViewReadyStateChange(int sequence, bool state) {
+    _viewStateSubject.addWhenMoreRecent(sequence, null, state);
   }
 
   @override
-  void onEngineReadyStateChange(int timestamp, bool state) {
-    _engineStateSubject.addWhenMoreRecent(timestamp, null, state);
+  void onEngineReadyStateChange(int sequence, bool state) {
+    _engineStateSubject.addWhenMoreRecent(sequence, null, state);
   }
 
   // Overridden methods
   @override
-  void onTabListChange(int timestamp, List<String?> tabIds) {
-    _tabListSubject.addWhenMoreRecent(
-      timestamp,
-      null,
-      tabIds.nonNulls.toList(),
-    );
+  void onTabListChange(int sequence, List<String?> tabIds) {
+    _tabListSubject.addWhenMoreRecent(sequence, null, tabIds.nonNulls.toList());
   }
 
   @override
-  void onSelectedTabChange(int timestamp, String? id) {
-    _selectedTabSubject.addWhenMoreRecent(timestamp, id, id);
+  void onSelectedTabChange(int sequence, String? id) {
+    _selectedTabSubject.addWhenMoreRecent(sequence, id, id);
   }
 
   @override
-  void onTabContentStateChange(int timestamp, TabContentState state) {
-    _tabContentSubject.addWhenMoreRecent(timestamp, state.id, state);
+  void onTabContentStateChange(int sequence, TabContentState state) {
+    _tabContentSubject.addWhenMoreRecent(sequence, state.id, state);
   }
 
   @override
-  void onHistoryStateChange(int timestamp, String id, HistoryState state) {
-    _historySubject.addWhenMoreRecent(timestamp, id, (
+  void onHistoryStateChange(int sequence, String id, HistoryState state) {
+    _historySubject.addWhenMoreRecent(sequence, id, (
       tabId: id,
       history: state,
     ));
   }
 
   @override
-  void onReaderableStateChange(
-    int timestamp,
-    String id,
-    ReaderableState state,
-  ) {
-    _readerableSubject.addWhenMoreRecent(timestamp, id, (
+  void onReaderableStateChange(int sequence, String id, ReaderableState state) {
+    _readerableSubject.addWhenMoreRecent(sequence, id, (
       tabId: id,
       readerable: state,
     ));
@@ -121,87 +117,91 @@ class GeckoEventService extends GeckoStateEvents {
 
   @override
   void onSecurityInfoStateChange(
-    int timestamp,
+    int sequence,
     String id,
     SecurityInfoState state,
   ) {
-    _securityInfoSubject.addWhenMoreRecent(timestamp, id, (
+    _securityInfoSubject.addWhenMoreRecent(sequence, id, (
       tabId: id,
       securityInfo: state,
     ));
   }
 
   @override
-  void onIconChange(int timestamp, String id, Uint8List? bytes) {
-    _iconChangeSubject.addWhenMoreRecent(timestamp, id, (
+  void onIconChange(int sequence, String id, Uint8List? bytes) {
+    _iconChangeSubject.addWhenMoreRecent(sequence, id, (
       tabId: id,
       bytes: bytes,
     ));
   }
 
   @override
-  void onIconUpdate(int timestamp, String url, Uint8List bytes) {
-    _iconUpdateSubject.addWhenMoreRecent(timestamp, url, (
+  void onIconUpdate(int sequence, String url, Uint8List bytes) {
+    _iconUpdateSubject.addWhenMoreRecent(sequence, url, (
       url: url,
       bytes: bytes,
     ));
   }
 
   @override
-  void onThumbnailChange(int timestamp, String id, Uint8List? bytes) {
-    _thumbnailSubject.addWhenMoreRecent(timestamp, id, (
+  void onThumbnailChange(int sequence, String id, Uint8List? bytes) {
+    _thumbnailSubject.addWhenMoreRecent(sequence, id, (
       tabId: id,
       bytes: bytes,
     ));
   }
 
   @override
-  void onFindResults(int timestamp, String id, List<FindResultState?> results) {
-    _findResultsSubject.addWhenMoreRecent(timestamp, id, (
+  void onFindResults(int sequence, String id, List<FindResultState?> results) {
+    _findResultsSubject.addWhenMoreRecent(sequence, id, (
       tabId: id,
       results: results.nonNulls.toList(),
     ));
   }
 
   @override
-  void onLongPress(int timestamp, String id, HitResult hitResult) {
-    _longPressSubject.addWhenMoreRecent(timestamp, id, (
+  void onLongPress(int sequence, String id, HitResult hitResult) {
+    _longPressSubject.addWhenMoreRecent(sequence, id, (
       tabId: id,
       hitResult: hitResult,
     ));
   }
 
   @override
-  void onTabAdded(int timestamp, String tabId) {
-    _tabAddedSubject.addWhenMoreRecent(timestamp, null, tabId);
+  void onTabAdded(int sequence, String tabId) {
+    _tabAddedSubject.addWhenMoreRecent(sequence, null, tabId);
   }
 
   // @override
-  // void onScrollChange(int timestamp, String tabId, int scrollY) {
-  //   _scrollEventSubject.addWhenMoreRecent(timestamp, tabId, (
+  // void onScrollChange(int sequence, String tabId, int scrollY) {
+  //   _scrollEventSubject.addWhenMoreRecent(sequence, tabId, (
   //     tabId: tabId,
   //     scrollY: scrollY,
   //   ));
   // }
 
   @override
-  void onPreferenceChange(int timestamp, GeckoPref value) {
-    _prefUpdateSubject.addWhenMoreRecent(timestamp, value.name, value);
+  void onPreferenceChange(int sequence, GeckoPref value) {
+    _prefUpdateSubject.addWhenMoreRecent(sequence, value.name, value);
   }
 
   @override
   void onContainerSiteAssignment(
-    int timestamp,
+    int sequence,
     ContainerSiteAssignment details,
   ) {
     _siteAssignementSubject.addWhenMoreRecent(
-      timestamp,
+      sequence,
       details.requestId,
       details,
     );
   }
 
   @override
+  void onMlProgress(int sequence, MlProgressData progress) {
+    _mlProgressSubject.addWhenMoreRecent(sequence, null, progress);
+  }
+
   void onMlProgress(int timestamp, MlProgressData progress) {
     _mlProgressSubject.addWhenMoreRecent(timestamp, null, progress);
   }
@@ -236,5 +236,6 @@ class GeckoEventService extends GeckoStateEvents {
     await _prefUpdateSubject.close();
     await _siteAssignementSubject.close();
     await _mlProgressSubject.close();
+    await _manifestUpdateSubject.close();
   }
 }

packages/flutter_mozilla_components/lib/src/domain/services/gecko_readerable.dart

@@ -27,8 +27,8 @@ class GeckoReaderableService extends ReaderViewController {
   }
 
   @override
-  void appearanceButtonVisibility(int timestamp, bool visible) {
-    _appearanceVisibility.addWhenMoreRecent(timestamp, null, visible);
+  void appearanceButtonVisibility(int sequence, bool visible) {
+    _appearanceVisibility.addWhenMoreRecent(sequence, null, visible);
   }
 
   GeckoReaderableService.setUp({

packages/flutter_mozilla_components/lib/src/domain/services/gecko_suggestions.dart

@@ -54,12 +54,12 @@ class GeckoSuggestionsService extends GeckoSuggestionEvents {
 
   @override
   void onSuggestionResult(
-    int timestamp,
+    int sequence,
     GeckoSuggestionType suggestionType,
     List<GeckoSuggestion> suggestions,
   ) {
     _suggestionsSubject.addWhenMoreRecent(
-      timestamp,
+      sequence,
       suggestionType,
       suggestions,
     );

packages/flutter_mozilla_components/lib/src/domain/services/gecko_tab_content.dart

@@ -28,8 +28,8 @@ class GeckoTabContentService extends GeckoTabContentEvents {
   }
 
   @override
-  void onContentUpdate(int timestamp, TabContent content) {
-    _contentSubject.addWhenMoreRecent(timestamp, content.tabId, content);
+  void onContentUpdate(int sequence, TabContent content) {
+    _contentSubject.addWhenMoreRecent(sequence, content.tabId, content);
   }
 
   Future<void> dispose() async {

packages/flutter_mozilla_components/lib/src/domain/services/gecko_viewport.dart

@@ -101,12 +101,12 @@ class GeckoViewportService extends GeckoViewportEvents {
 
   @override
   void onKeyboardVisibilityChanged(
-    int timestamp,
+    int sequence,
     int heightPx,
     bool isVisible,
     bool isAnimating,
   ) {
-    _keyboardSubject.addWhenMoreRecent(timestamp, null, (
+    _keyboardSubject.addWhenMoreRecent(sequence, null, (
       heightPx: heightPx,
       isVisible: isVisible,
       isAnimating: isAnimating,

packages/flutter_mozilla_components/lib/src/extensions/subject.dart

@@ -9,17 +9,29 @@ import 'package:rxdart/rxdart.dart';
 final _lastEventTimes = <Subject, Map<dynamic, int>>{};
 
 extension SubjectAddRecent<T> on Subject<T> {
-  void addWhenMoreRecent(int timestamp, dynamic identifier, T value) {
+  /// Adds [value] to this Subject only if [sequence] is greater than
+  /// the last sequence number for this [identifier].
+  ///
+  /// Uses atomic event sequence numbers (from native EventSequence) to ensure
+  /// events are processed in order and prevent out-of-order updates.
+  /// Sequence numbers are monotonically increasing integers (0, 1, 2, ...).
+  void addWhenMoreRecent(int sequence, dynamic identifier, T value) {
     _lastEventTimes[this] ??= {};
 
-    if ((_lastEventTimes[this]?[identifier] ?? 0) < timestamp) {
-      _lastEventTimes[this]![identifier] = timestamp;
+    if ((_lastEventTimes[this]?[identifier] ?? 0) < sequence) {
+      _lastEventTimes[this]![identifier] = sequence;
       add(value);
     }
   }
 
+  /// Updates this BehaviorSubject only if [sequence] is greater than
+  /// the last sequence number for this [identifier].
+  ///
+  /// Uses atomic event sequence numbers (from native EventSequence) to ensure
+  /// events are processed in order and prevent out-of-order updates.
+  /// Sequence numbers are monotonically increasing integers (0, 1, 2, ...).
   void updateWhenMoreRecent(
-    int timestamp,
+    int sequence,
     dynamic identifier,
     T Function(T? currentValue) update,
   ) {
@@ -27,8 +39,8 @@ extension SubjectAddRecent<T> on Subject<T> {
 
     _lastEventTimes[this] ??= {};
 
-    if ((_lastEventTimes[this]?[identifier] ?? 0) < timestamp) {
-      _lastEventTimes[this]![identifier] = timestamp;
+    if ((_lastEventTimes[this]?[identifier] ?? 0) < sequence) {
+      _lastEventTimes[this]![identifier] = sequence;
       add(update((this as BehaviorSubject<T>).valueOrNull));
     }
   }