From 15dfcc1a4f3eff5b24cdce4bef8a70d28457b25d Mon Sep 17 00:00:00 2001 From: Fabian Freund Date: Tue, 18 Feb 2025 16:06:49 +0100 Subject: [PATCH] fix linter rules and format files --- app/analysis_options.yaml | 7 ++++--- app/lib/core/providers.dart | 2 +- app/lib/domain/services/app_initialization.dart | 6 +++--- app/lib/domain/services/generic_website.dart | 4 ++-- app/lib/extensions/nullable.dart | 2 +- .../app_widget/domain/services/home_widget.dart | 2 +- app/lib/features/bangs/data/services/source.dart | 2 +- .../features/chat_store/domain/chat_memory.dart | 2 +- .../chat_archive/presentation/screens/detail.dart | 2 +- .../geckoview/domain/controllers/bottom_sheet.dart | 2 +- .../domain/controllers/overlay_dialog.dart | 2 +- .../features/browser/domain/entities/sheet.dart | 1 - .../features/browser/domain/providers.dart | 14 +++++++++++--- .../presentation/dialogs/web_page_dialog.dart | 2 +- .../presentation/widgets/sheets/create_tab.dart | 2 +- .../presentation/widgets/sheets/view_tabs.dart | 5 +++-- .../widgets/search_modules/tab_search.dart | 4 ++-- .../tabs/presentation/screens/container_edit.dart | 2 +- .../tabs/utils/setting_groups_serializer.dart | 4 ++-- .../features/kagi/data/services/autosuggest.dart | 2 +- .../domain/repositories/search_suggestions.dart | 4 ++-- .../kagi/presentation/tabs/summarize_tab.dart | 2 +- app/lib/features/search/domain/fts_tokenizer.dart | 2 +- .../presentation/screens/web_engine_settings.dart | 1 + .../domain/services/sharing_intent.dart | 4 ++-- .../presentation/controllers/start_tor_proxy.dart | 1 + app/lib/features/tor/utils/tor_entrypoint.dart | 2 +- app/lib/presentation/hooks/cached_future.dart | 2 +- .../presentation/hooks/listenable_callback.dart | 2 +- app/lib/presentation/hooks/on_dispose.dart | 2 +- app/lib/presentation/hooks/on_initialization.dart | 2 +- app/lib/presentation/hooks/sync_page_tab.dart | 2 +- .../analysis_options.yaml | 7 ++++--- .../lib/src/data/models/load_url_flags.dart | 2 +- .../lib/src/domain/services/gecko_addon.dart | 12 ++++++------ .../lib/src/domain/services/gecko_event.dart | 14 +++++++------- .../lib/src/geckoview_widget.dart | 2 +- packages/sqlite3_vec/analysis_options.yaml | 7 ++++--- packages/sqlite3_vec/lib/sqlite3_vec.dart | 2 +- 39 files changed, 77 insertions(+), 64 deletions(-) diff --git a/app/analysis_options.yaml b/app/analysis_options.yaml index 44157fb7..df9bf7d1 100644 --- a/app/analysis_options.yaml +++ b/app/analysis_options.yaml @@ -16,9 +16,10 @@ include: package:lint/strict.yaml linter: rules: - - unawaited_futures - - discarded_futures - - collection_methods_unrelated_type + unawaited_futures: true + discarded_futures: true + collection_methods_unrelated_type: true + require_trailing_commas: false analyzer: errors: diff --git a/app/lib/core/providers.dart b/app/lib/core/providers.dart index 3b535970..dd7ce89f 100644 --- a/app/lib/core/providers.dart +++ b/app/lib/core/providers.dart @@ -13,7 +13,7 @@ GoRouter router(Ref ref) { @Riverpod() class WillAcceptDrop extends _$WillAcceptDrop { - // ignore: use_setters_to_change_properties + // ignore: use_setters_to_change_properties api decision void setData(DropTargetData data) { state = data; } diff --git a/app/lib/domain/services/app_initialization.dart b/app/lib/domain/services/app_initialization.dart index 2caf198d..35fb894a 100644 --- a/app/lib/domain/services/app_initialization.dart +++ b/app/lib/domain/services/app_initialization.dart @@ -22,7 +22,7 @@ class AppInitializationService extends _$AppInitializationService { initialized: false, stage: 'Loading Package Info...', errors: List.empty(), - ),); + )); return ref.read(packageInfoProvider.future); } @@ -32,7 +32,7 @@ class AppInitializationService extends _$AppInitializationService { initialized: false, stage: 'Synchronizing Bangs...', errors: List.empty(), - ),); + )); return ref .read(bangSyncRepositoryProvider.notifier) @@ -61,6 +61,6 @@ class AppInitializationService extends _$AppInitializationService { initialized: false, stage: null, errors: List.empty(), - ),); + )); } } diff --git a/app/lib/domain/services/generic_website.dart b/app/lib/domain/services/generic_website.dart index 72d3f1c1..9e385c44 100644 --- a/app/lib/domain/services/generic_website.dart +++ b/app/lib/domain/services/generic_website.dart @@ -204,7 +204,7 @@ class GenericWebsiteService extends _$GenericWebsiteService { 'title': title, 'resources': resources.map(_serializeResource).toList(), }; - }, [response.body, url.toString()],); + }, [response.body, url.toString()]); final resources = (result['resources']! as List>) @@ -220,7 +220,7 @@ class GenericWebsiteService extends _$GenericWebsiteService { title: result['title'] as String?, favicon: favicon, ); - }, exceptionHandler: handleHttpError,); + }, exceptionHandler: handleHttpError); } Future getCachedIcon(Uri url) async { diff --git a/app/lib/extensions/nullable.dart b/app/lib/extensions/nullable.dart index 9666ff26..59cfa6f0 100644 --- a/app/lib/extensions/nullable.dart +++ b/app/lib/extensions/nullable.dart @@ -1,7 +1,7 @@ extension NullableX on T? { @pragma('vm:prefer-inline') R? mapNotNull(R? Function(T) callback) { - // ignore: null_check_on_nullable_type_parameter + // ignore: null_check_on_nullable_type_parameter validated return (this != null) ? callback(this!) : null; } } diff --git a/app/lib/features/app_widget/domain/services/home_widget.dart b/app/lib/features/app_widget/domain/services/home_widget.dart index ef6df0cc..649ef0c1 100644 --- a/app/lib/features/app_widget/domain/services/home_widget.dart +++ b/app/lib/features/app_widget/domain/services/home_widget.dart @@ -13,7 +13,7 @@ FutureOr widgetPinnable(Ref ref) async { @Riverpod() Raw> appWidgetLaunchStream(Ref ref) { - // ignore: discarded_futures + // ignore: discarded_futures is used as stream final initialStream = HomeWidget.initiallyLaunchedFromHomeWidget().asStream(); return ConcatStream([ diff --git a/app/lib/features/bangs/data/services/source.dart b/app/lib/features/bangs/data/services/source.dart index ff189401..8c9bb609 100644 --- a/app/lib/features/bangs/data/services/source.dart +++ b/app/lib/features/bangs/data/services/source.dart @@ -35,6 +35,6 @@ class BangSourceService extends _$BangSourceService { return bang; }).toList(), ); - }, exceptionHandler: handleHttpError,); + }, exceptionHandler: handleHttpError); } } diff --git a/app/lib/features/chat/features/chat_store/domain/chat_memory.dart b/app/lib/features/chat/features/chat_store/domain/chat_memory.dart index 49c2e083..fd7d3630 100644 --- a/app/lib/features/chat/features/chat_store/domain/chat_memory.dart +++ b/app/lib/features/chat/features/chat_store/domain/chat_memory.dart @@ -1,4 +1,4 @@ -// ignore_for_file: avoid_dynamic_calls +// ignore_for_file: avoid_dynamic_calls we know what we do import 'dart:convert'; diff --git a/app/lib/features/chat_archive/presentation/screens/detail.dart b/app/lib/features/chat_archive/presentation/screens/detail.dart index 5a7cd03c..4ecb2881 100644 --- a/app/lib/features/chat_archive/presentation/screens/detail.dart +++ b/app/lib/features/chat_archive/presentation/screens/detail.dart @@ -66,7 +66,7 @@ class ChatArchiveDetailScreen extends HookConsumerWidget { ); } }, - // ignore: deprecated_member_use + // ignore: deprecated_member_use use this icon for now leadingIcon: const Icon(MdiIcons.languageMarkdown), child: const Text('Copy as markdown'), ), diff --git a/app/lib/features/geckoview/domain/controllers/bottom_sheet.dart b/app/lib/features/geckoview/domain/controllers/bottom_sheet.dart index 2eb0e2b2..0874c9a6 100644 --- a/app/lib/features/geckoview/domain/controllers/bottom_sheet.dart +++ b/app/lib/features/geckoview/domain/controllers/bottom_sheet.dart @@ -15,7 +15,7 @@ class BottomSheetController extends _$BottomSheetController { return ref.watch(createTabStreamProvider).valueOrNull; } - // ignore: use_setters_to_change_properties + // ignore: use_setters_to_change_properties api decision void show(Sheet sheet) { state = sheet; } diff --git a/app/lib/features/geckoview/domain/controllers/overlay_dialog.dart b/app/lib/features/geckoview/domain/controllers/overlay_dialog.dart index 8ed11080..78389a08 100644 --- a/app/lib/features/geckoview/domain/controllers/overlay_dialog.dart +++ b/app/lib/features/geckoview/domain/controllers/overlay_dialog.dart @@ -10,7 +10,7 @@ class OverlayDialogController extends _$OverlayDialogController { return null; } - // ignore: use_setters_to_change_properties + // ignore: use_setters_to_change_properties api decision void show(Widget dialog) { state = dialog; } diff --git a/app/lib/features/geckoview/features/browser/domain/entities/sheet.dart b/app/lib/features/geckoview/features/browser/domain/entities/sheet.dart index 23fe91ba..d6b3b681 100644 --- a/app/lib/features/geckoview/features/browser/domain/entities/sheet.dart +++ b/app/lib/features/geckoview/features/browser/domain/entities/sheet.dart @@ -1,7 +1,6 @@ import 'package:fast_equatable/fast_equatable.dart'; import 'package:lensai/features/kagi/data/entities/modes.dart'; -// ignore: missing_override_of_must_be_overridden sealed class Sheet with FastEquatable {} class CreateTabSheet extends Sheet { diff --git a/app/lib/features/geckoview/features/browser/domain/providers.dart b/app/lib/features/geckoview/features/browser/domain/providers.dart index 380ac5a8..b00cc973 100644 --- a/app/lib/features/geckoview/features/browser/domain/providers.dart +++ b/app/lib/features/geckoview/features/browser/domain/providers.dart @@ -1,5 +1,3 @@ -// ignore_for_file: use_setters_to_change_properties - import 'dart:async'; import 'package:lensai/data/models/equatable_iterable.dart'; @@ -21,6 +19,8 @@ part 'providers.g.dart'; @Riverpod(keepAlive: true) class SelectedBangTrigger extends _$SelectedBangTrigger { + // ignore: document_ignores api decision + // ignore: use_setters_to_change_properties void setTrigger(String trigger) { state = trigger; } @@ -60,6 +60,8 @@ class SelectedBangData extends _$SelectedBangData { @Riverpod(keepAlive: true) class LastUsedAssistantMode extends _$LastUsedAssistantMode { + // ignore: document_ignores api decision + // ignore: use_setters_to_change_properties void update(AssistantMode mode) { state = mode; } @@ -72,6 +74,8 @@ class LastUsedAssistantMode extends _$LastUsedAssistantMode { @Riverpod(keepAlive: true) class ActiveResearchVariant extends _$ActiveResearchVariant { + // ignore: document_ignores api decision + // ignore: use_setters_to_change_properties void update(ResearchVariant mode) { state = mode; } @@ -84,6 +88,8 @@ class ActiveResearchVariant extends _$ActiveResearchVariant { @Riverpod(keepAlive: true) class ActiveChatModel extends _$ActiveChatModel { + // ignore: document_ignores api decision + // ignore: use_setters_to_change_properties void update(ChatModel model) { state = model; } @@ -96,6 +102,8 @@ class ActiveChatModel extends _$ActiveChatModel { @Riverpod(keepAlive: true) class ShowFindInPage extends _$ShowFindInPage { + // ignore: document_ignores api decision + // ignore: use_setters_to_change_properties void update(bool show) { state = show; } @@ -135,7 +143,7 @@ EquatableCollection> availableTabStates( return EquatableCollection({ for (final tabId in availableTabs.collection) if (tabStates.containsKey(tabId)) tabId: tabStates[tabId]!, - }, immutable: true,); + }, immutable: true); } @Riverpod() diff --git a/app/lib/features/geckoview/features/browser/presentation/dialogs/web_page_dialog.dart b/app/lib/features/geckoview/features/browser/presentation/dialogs/web_page_dialog.dart index e085d004..eeaaed0f 100644 --- a/app/lib/features/geckoview/features/browser/presentation/dialogs/web_page_dialog.dart +++ b/app/lib/features/geckoview/features/browser/presentation/dialogs/web_page_dialog.dart @@ -261,7 +261,7 @@ class WebPageDialog extends HookConsumerWidget { await Share.shareXFiles([ file, - ], subject: precachedInfo?.title,); + ], subject: precachedInfo?.title); } }); } diff --git a/app/lib/features/geckoview/features/browser/presentation/widgets/sheets/create_tab.dart b/app/lib/features/geckoview/features/browser/presentation/widgets/sheets/create_tab.dart index 629224b5..c234b9a1 100644 --- a/app/lib/features/geckoview/features/browser/presentation/widgets/sheets/create_tab.dart +++ b/app/lib/features/geckoview/features/browser/presentation/widgets/sheets/create_tab.dart @@ -67,7 +67,7 @@ class CreateTabSheetWidget extends HookConsumerWidget { onActiveToolChanged?.call(KagiTool.values[initialIndex]); }); return null; - }, [initialIndex],); + }, [initialIndex]); return Column( mainAxisSize: MainAxisSize.min, diff --git a/app/lib/features/geckoview/features/browser/presentation/widgets/sheets/view_tabs.dart b/app/lib/features/geckoview/features/browser/presentation/widgets/sheets/view_tabs.dart index b623f2df..fb25649c 100644 --- a/app/lib/features/geckoview/features/browser/presentation/widgets/sheets/view_tabs.dart +++ b/app/lib/features/geckoview/features/browser/presentation/widgets/sheets/view_tabs.dart @@ -255,6 +255,7 @@ class ViewTabsSheetWidget extends HookConsumerWidget { final filteredTabIds = ref.watch( seamlessFilteredTabIdsProvider( TabSearchPartition.preview, + // ignore: document_ignores using fast equatable // ignore: provider_parameters ContainerFilterById(containerId: container), ), @@ -294,7 +295,7 @@ class ViewTabsSheetWidget extends HookConsumerWidget { } return null; - }, [filteredTabIds, activeTab],); + }, [filteredTabIds, activeTab]); final tabs = useMemoized(() { return filteredTabIds.collection @@ -346,7 +347,7 @@ class ViewTabsSheetWidget extends HookConsumerWidget { ), ) .toList(); - }, [filteredTabIds, activeTab],); + }, [filteredTabIds, activeTab]); return Padding( padding: const EdgeInsets.symmetric(horizontal: 4.0), diff --git a/app/lib/features/geckoview/features/search/presentation/widgets/search_modules/tab_search.dart b/app/lib/features/geckoview/features/search/presentation/widgets/search_modules/tab_search.dart index d589a3a0..4de1c4b4 100644 --- a/app/lib/features/geckoview/features/search/presentation/widgets/search_modules/tab_search.dart +++ b/app/lib/features/geckoview/features/search/presentation/widgets/search_modules/tab_search.dart @@ -51,9 +51,9 @@ class TabSearch extends HookConsumerWidget { .read(tabSearchRepositoryProvider(TabSearchPartition.search).notifier) .addQuery( searchTextController.text, - // ignore: avoid_redundant_argument_values + // ignore: avoid_redundant_argument_values dont break things matchPrefix: _matchPrefix, - // ignore: avoid_redundant_argument_values + // ignore: avoid_redundant_argument_values dont break things matchSuffix: _matchSuffix, ); }); diff --git a/app/lib/features/geckoview/features/tabs/presentation/screens/container_edit.dart b/app/lib/features/geckoview/features/tabs/presentation/screens/container_edit.dart index b82e2698..47a92e58 100644 --- a/app/lib/features/geckoview/features/tabs/presentation/screens/container_edit.dart +++ b/app/lib/features/geckoview/features/tabs/presentation/screens/container_edit.dart @@ -64,7 +64,7 @@ class ContainerEditScreen extends HookConsumerWidget { title: Text(switch (_mode) { _DialogMode.create => 'New Container', _DialogMode.edit => 'Edit Container', - },), + }), actions: [ IconButton( onPressed: () async { diff --git a/app/lib/features/geckoview/features/tabs/utils/setting_groups_serializer.dart b/app/lib/features/geckoview/features/tabs/utils/setting_groups_serializer.dart index 32d3c0fd..d1206521 100644 --- a/app/lib/features/geckoview/features/tabs/utils/setting_groups_serializer.dart +++ b/app/lib/features/geckoview/features/tabs/utils/setting_groups_serializer.dart @@ -1,3 +1,5 @@ +// ignore_for_file: avoid_dynamic_calls wo know what we do + import 'package:lensai/features/geckoview/features/preferences/data/models/preference_setting.dart'; enum PreferencePartition { @@ -19,9 +21,7 @@ Map deserializePreferenceSettingGroups( (key, value) => MapEntry( key, PreferenceSettingGroup( - // ignore: avoid_dynamic_calls description: value['description'] as String?, - // ignore: avoid_dynamic_calls settings: (value['preferences'] as Map).map( (key, value) => MapEntry( key, diff --git a/app/lib/features/kagi/data/services/autosuggest.dart b/app/lib/features/kagi/data/services/autosuggest.dart index e1ec6788..566532b3 100644 --- a/app/lib/features/kagi/data/services/autosuggest.dart +++ b/app/lib/features/kagi/data/services/autosuggest.dart @@ -33,6 +33,6 @@ class KagiAutosuggestService extends _$KagiAutosuggestService final List resultList => resultList.cast(), _ => [], }; - }, exceptionHandler: handleHttpError,); + }, exceptionHandler: handleHttpError); } } diff --git a/app/lib/features/kagi/domain/repositories/search_suggestions.dart b/app/lib/features/kagi/domain/repositories/search_suggestions.dart index 69c92f19..9f5003a2 100644 --- a/app/lib/features/kagi/domain/repositories/search_suggestions.dart +++ b/app/lib/features/kagi/domain/repositories/search_suggestions.dart @@ -43,9 +43,9 @@ class SearchSuggestionsRepository extends _$SearchSuggestionsRepository { } return suggestionsProvider - // ignore: discarded_futures + // ignore: discarded_futures is used as stream .getSuggestions(query) - // ignore: discarded_futures + // ignore: discarded_futures is used as stream .then((result) { result.onSuccess((result) { _cache.set(query, result); diff --git a/app/lib/features/kagi/presentation/tabs/summarize_tab.dart b/app/lib/features/kagi/presentation/tabs/summarize_tab.dart index ad9ac37f..baff8137 100644 --- a/app/lib/features/kagi/presentation/tabs/summarize_tab.dart +++ b/app/lib/features/kagi/presentation/tabs/summarize_tab.dart @@ -107,7 +107,7 @@ class SummarizeTab extends HookConsumerWidget { textController.addListener(debounce); return () => textController.removeListener(debounce); - }, [textController],); + }, [textController]); return Column( mainAxisSize: MainAxisSize.min, diff --git a/app/lib/features/search/domain/fts_tokenizer.dart b/app/lib/features/search/domain/fts_tokenizer.dart index 3d55c52e..b35fea04 100644 --- a/app/lib/features/search/domain/fts_tokenizer.dart +++ b/app/lib/features/search/domain/fts_tokenizer.dart @@ -198,7 +198,7 @@ final class PrefixQueryBuilder extends FtsQueryBuilder { } return 'NEAR(${phrase.map((bareword) => '$bareword*').join(' ')})'; - }, ' OR ',); + }, ' OR '); } } diff --git a/app/lib/features/settings/presentation/screens/web_engine_settings.dart b/app/lib/features/settings/presentation/screens/web_engine_settings.dart index ad8060d8..8d37ab35 100644 --- a/app/lib/features/settings/presentation/screens/web_engine_settings.dart +++ b/app/lib/features/settings/presentation/screens/web_engine_settings.dart @@ -100,6 +100,7 @@ class WebEngineSettingsScreen extends HookConsumerWidget { subtitle: const Text( 'While turning off JavaScript boosts security, privacy, and speed, it may cause some sites to not work as intended.', ), + // ignore: deprecated_member_use use this icon for now secondary: const Icon(MdiIcons.languageJavascript), value: engineSettings.javascriptEnabled, onChanged: (value) async { diff --git a/app/lib/features/share_intent/domain/services/sharing_intent.dart b/app/lib/features/share_intent/domain/services/sharing_intent.dart index ac488b75..36fabb34 100644 --- a/app/lib/features/share_intent/domain/services/sharing_intent.dart +++ b/app/lib/features/share_intent/domain/services/sharing_intent.dart @@ -53,9 +53,9 @@ final _sharingIntentTransformer = Raw> sharingIntentStream(Ref ref) { final initialStream = FlutterSharingIntent.instance - // ignore: discarded_futures + // ignore: discarded_futures is used as stream .getInitialSharing() - // ignore: discarded_futures + // ignore: discarded_futures is used as stream .then((event) { FlutterSharingIntent.instance.reset(); return event; diff --git a/app/lib/features/tor/presentation/controllers/start_tor_proxy.dart b/app/lib/features/tor/presentation/controllers/start_tor_proxy.dart index 94fe2503..24d6c8f8 100644 --- a/app/lib/features/tor/presentation/controllers/start_tor_proxy.dart +++ b/app/lib/features/tor/presentation/controllers/start_tor_proxy.dart @@ -9,6 +9,7 @@ part 'start_tor_proxy.g.dart'; @Riverpod() class StartProxyController extends _$StartProxyController { + // ignore: document_ignores is used for dialog // ignore: avoid_build_context_in_providers Future maybeStartProxy(BuildContext context) async { final torProxyRunning = ref.read(torProxyServiceProvider); diff --git a/app/lib/features/tor/utils/tor_entrypoint.dart b/app/lib/features/tor/utils/tor_entrypoint.dart index 78e7f3ce..d5279306 100644 --- a/app/lib/features/tor/utils/tor_entrypoint.dart +++ b/app/lib/features/tor/utils/tor_entrypoint.dart @@ -2,7 +2,7 @@ import 'package:flutter_background_service/flutter_background_service.dart'; import 'package:tor/tor.dart'; @pragma('vm:entry-point') -void onStart(ServiceInstance service) async { +Future onStart(ServiceInstance service) async { await Tor.init(); final portSub = Tor.instance.events.stream.listen((port) { diff --git a/app/lib/presentation/hooks/cached_future.dart b/app/lib/presentation/hooks/cached_future.dart index 1f7e55f5..5d96d3cd 100644 --- a/app/lib/presentation/hooks/cached_future.dart +++ b/app/lib/presentation/hooks/cached_future.dart @@ -5,7 +5,7 @@ AsyncSnapshot useCachedFuture( Future Function() valueBuilder, [ List keys = const [], ]) { - // ignore: discarded_futures + // ignore: discarded_futures is used final cachedFuture = useMemoized(valueBuilder, keys); return useFuture(cachedFuture); } diff --git a/app/lib/presentation/hooks/listenable_callback.dart b/app/lib/presentation/hooks/listenable_callback.dart index 96184a74..5d223489 100644 --- a/app/lib/presentation/hooks/listenable_callback.dart +++ b/app/lib/presentation/hooks/listenable_callback.dart @@ -9,5 +9,5 @@ void useListenableCallback( useEffect(() { listenable?.addListener(callback); return () => listenable?.removeListener(callback); - }, keys ?? [listenable],); + }, keys ?? [listenable]); } diff --git a/app/lib/presentation/hooks/on_dispose.dart b/app/lib/presentation/hooks/on_dispose.dart index 5299609e..762ee548 100644 --- a/app/lib/presentation/hooks/on_dispose.dart +++ b/app/lib/presentation/hooks/on_dispose.dart @@ -4,5 +4,5 @@ import 'package:flutter_hooks/flutter_hooks.dart'; void useOnDispose(VoidCallback onDispose) { useEffect(() { return onDispose; - }, const [],); + }, const []); } diff --git a/app/lib/presentation/hooks/on_initialization.dart b/app/lib/presentation/hooks/on_initialization.dart index a4423140..878dc8f6 100644 --- a/app/lib/presentation/hooks/on_initialization.dart +++ b/app/lib/presentation/hooks/on_initialization.dart @@ -6,5 +6,5 @@ void useOnInitialization(FutureOr Function() callback) { useEffect(() { Future.microtask(callback); return null; - }, [],); + }, []); } diff --git a/app/lib/presentation/hooks/sync_page_tab.dart b/app/lib/presentation/hooks/sync_page_tab.dart index 02895486..f7de17f3 100644 --- a/app/lib/presentation/hooks/sync_page_tab.dart +++ b/app/lib/presentation/hooks/sync_page_tab.dart @@ -32,5 +32,5 @@ void useSyncPageWithTab( tabController.removeListener(syncPage); pageController.removeListener(syncTab); }; - }, [tabController, pageController],); + }, [tabController, pageController]); } diff --git a/packages/flutter_mozilla_components/analysis_options.yaml b/packages/flutter_mozilla_components/analysis_options.yaml index 4d829f60..29144708 100644 --- a/packages/flutter_mozilla_components/analysis_options.yaml +++ b/packages/flutter_mozilla_components/analysis_options.yaml @@ -16,9 +16,10 @@ include: package:lint/package.yaml linter: rules: - - unawaited_futures - - discarded_futures - - collection_methods_unrelated_type + unawaited_futures: true + discarded_futures: true + collection_methods_unrelated_type: true + require_trailing_commas: false analyzer: plugins: diff --git a/packages/flutter_mozilla_components/lib/src/data/models/load_url_flags.dart b/packages/flutter_mozilla_components/lib/src/data/models/load_url_flags.dart index 8c2c4fb8..2fdb0246 100644 --- a/packages/flutter_mozilla_components/lib/src/data/models/load_url_flags.dart +++ b/packages/flutter_mozilla_components/lib/src/data/models/load_url_flags.dart @@ -1,4 +1,4 @@ -// ignore_for_file: constant_identifier_names, non_constant_identifier_names +// ignore_for_file: constant_identifier_names, non_constant_identifier_names copied from kotlin import 'package:flutter_mozilla_components/src/pigeons/gecko.g.dart'; diff --git a/packages/flutter_mozilla_components/lib/src/domain/services/gecko_addon.dart b/packages/flutter_mozilla_components/lib/src/domain/services/gecko_addon.dart index 55fe2fe9..dd70a489 100644 --- a/packages/flutter_mozilla_components/lib/src/domain/services/gecko_addon.dart +++ b/packages/flutter_mozilla_components/lib/src/domain/services/gecko_addon.dart @@ -50,12 +50,12 @@ class GeckoAddonService extends GeckoAddonEvents { _browserExtensionSubject.addWhenMoreRecent(timestamp, extensionId, ( extensionId: extensionId, data: null, - ),); + )); case WebExtensionActionType.page: _pageExtensionSubject.addWhenMoreRecent(timestamp, extensionId, ( extensionId: extensionId, data: null, - ),); + )); } } @@ -71,12 +71,12 @@ class GeckoAddonService extends GeckoAddonEvents { _browserIconSubject.addWhenMoreRecent(timestamp, extensionId, ( extensionId: extensionId, bytes: icon, - ),); + )); case WebExtensionActionType.page: _pageIconSubject.addWhenMoreRecent(timestamp, extensionId, ( extensionId: extensionId, bytes: icon, - ),); + )); } } @@ -92,12 +92,12 @@ class GeckoAddonService extends GeckoAddonEvents { _browserExtensionSubject.addWhenMoreRecent(timestamp, extensionId, ( extensionId: extensionId, data: extensionData, - ),); + )); case WebExtensionActionType.page: _pageExtensionSubject.addWhenMoreRecent(timestamp, extensionId, ( extensionId: extensionId, data: extensionData, - ),); + )); } } diff --git a/packages/flutter_mozilla_components/lib/src/domain/services/gecko_event.dart b/packages/flutter_mozilla_components/lib/src/domain/services/gecko_event.dart index 9a572a48..d742f04f 100644 --- a/packages/flutter_mozilla_components/lib/src/domain/services/gecko_event.dart +++ b/packages/flutter_mozilla_components/lib/src/domain/services/gecko_event.dart @@ -85,7 +85,7 @@ class GeckoEventService extends GeckoStateEvents { _historySubject.addWhenMoreRecent(timestamp, id, ( tabId: id, history: state, - ),); + )); } @override @@ -97,7 +97,7 @@ class GeckoEventService extends GeckoStateEvents { _readerableSubject.addWhenMoreRecent(timestamp, id, ( tabId: id, readerable: state, - ),); + )); } @override @@ -109,7 +109,7 @@ class GeckoEventService extends GeckoStateEvents { _securityInfoSubject.addWhenMoreRecent(timestamp, id, ( tabId: id, securityInfo: state, - ),); + )); } @override @@ -117,7 +117,7 @@ class GeckoEventService extends GeckoStateEvents { _iconChangeSubject.addWhenMoreRecent(timestamp, id, ( tabId: id, bytes: bytes, - ),); + )); } @override @@ -125,7 +125,7 @@ class GeckoEventService extends GeckoStateEvents { _iconUpdateSubject.addWhenMoreRecent(timestamp, url, ( url: url, bytes: bytes, - ),); + )); } @override @@ -133,7 +133,7 @@ class GeckoEventService extends GeckoStateEvents { _thumbnailSubject.addWhenMoreRecent(timestamp, id, ( tabId: id, bytes: bytes, - ),); + )); } @override @@ -141,7 +141,7 @@ class GeckoEventService extends GeckoStateEvents { _findResultsSubject.addWhenMoreRecent(timestamp, id, ( tabId: id, results: results.nonNulls.toList(), - ),); + )); } @override diff --git a/packages/flutter_mozilla_components/lib/src/geckoview_widget.dart b/packages/flutter_mozilla_components/lib/src/geckoview_widget.dart index a59f21f3..4bcd0169 100644 --- a/packages/flutter_mozilla_components/lib/src/geckoview_widget.dart +++ b/packages/flutter_mozilla_components/lib/src/geckoview_widget.dart @@ -77,7 +77,7 @@ class _GeckoViewState extends State { }); }); }) - // ignore: discarded_futures + // ignore: discarded_futures that hos it is done in docs ..create(); }, ); diff --git a/packages/sqlite3_vec/analysis_options.yaml b/packages/sqlite3_vec/analysis_options.yaml index 4d829f60..29144708 100644 --- a/packages/sqlite3_vec/analysis_options.yaml +++ b/packages/sqlite3_vec/analysis_options.yaml @@ -16,9 +16,10 @@ include: package:lint/package.yaml linter: rules: - - unawaited_futures - - discarded_futures - - collection_methods_unrelated_type + unawaited_futures: true + discarded_futures: true + collection_methods_unrelated_type: true + require_trailing_commas: false analyzer: plugins: diff --git a/packages/sqlite3_vec/lib/sqlite3_vec.dart b/packages/sqlite3_vec/lib/sqlite3_vec.dart index cc1c400a..b5d05ad7 100644 --- a/packages/sqlite3_vec/lib/sqlite3_vec.dart +++ b/packages/sqlite3_vec/lib/sqlite3_vec.dart @@ -5,7 +5,7 @@ import 'package:sqlite3/sqlite3.dart'; const String _libName = 'vec0'; -// ignore: avoid_classes_with_only_static_members +// ignore: avoid_classes_with_only_static_members better like this class Sqlite3Vec { static void ensureExtensionLoaded() { final libPath = switch (Platform.operatingSystem) {